Opened on 06/07/2018 at 02:49:41 PM
Closed on 07/18/2018 at 12:21:03 PM
Last modified on 08/21/2018 at 04:33:10 PM
#6739 closed change (fixed)
Update code to work with FilterStorage.knownSubscriptions as a Map object
| Reported by: | mjethani | Assignee: | greiner |
|---|---|---|---|
| Priority: | P1 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | greiner, saroyanm, agiammarchi, wspee | Blocked By: | |
| Blocking: | #6753 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by greiner)
Background
FilterStorage.knownSubscriptions is now a Map object (changeset 212fe705ab82).
What to change
Modify any code that assumes the type of FilterStorage.knownSubscriptions to be Object, treat it as a Map object now (e.g. use Map.has instead of the in operator).
See also ui#110
Hints for testers
- Removing a filter list should still work
- En-/disabling a filter list should still work
- Anti-adblock notification should still work (even after the anti-adblock filter list receives an update)
Attachments (0)
Change History (8)
comment:1 Changed on 06/07/2018 at 03:55:35 PM by greiner
- Cc agiammarchi wspee added
- Description modified (diff)
- Priority changed from Unknown to P1
- Ready set
comment:2 Changed on 06/12/2018 at 05:30:38 PM by greiner
- Description modified (diff)
- Owner set to greiner
comment:3 Changed on 06/13/2018 at 12:31:59 PM by greiner
- Blocked By 6559 added
comment:4 Changed on 06/20/2018 at 09:42:36 AM by wspee
- Blocking 6753 added
comment:5 Changed on 07/12/2018 at 05:22:00 PM by greiner
Done: https://gitlab.com/eyeo/adblockplus/adblockplusui/commit/93e8b26e725870e4aa2fd09ea470a2bf5ac18f08
Keeping this ticket open since it requires #6559 before it can be used in Platform.
comment:6 Changed on 07/18/2018 at 12:13:12 PM by abpbot
A commit referencing this issue has landed:
Issue 6739 - Adapted code to work with Map implementation of FilterStorage.knownSubscriptions
Note: See
TracTickets for help on using
tickets.
Thanks for the heads-up. Note that the adblockpluscore dependency is defined by adblockpluschrome so I've removed the dependency update part of the change.