Opened on 06/18/2018 at 05:24:10 PM
Closed on 07/05/2018 at 11:07:02 AM
Last modified on 10/26/2018 at 10:19:17 AM
#6749 closed change (fixed)
Make first-run page consistent with website installation flow
| Reported by: | greiner | Assignee: | greiner |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #6892 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/adblockplusui/merge_requests/46 |
||
Description (last modified by greiner)
Background
See https://gitlab.com/eyeo/adblockplus/adblockplusui/issues/62
What to change
See https://gitlab.com/eyeo/specs/spec/merge_requests/148
Notes for dependency update
Update any references to "firstRun.html" to "first-run.html" and make the following changes to metadata.chrome:
- Add
- skin/icons/first-run/checkmark-header.svg
- skin/icons/first-run/checkmark.svg
- skin/icons/first-run/lock.svg
- skin/icons/first-run/rocket.svg
- skin/icons/web/navbar-logo.svg
- skin/web.css
- Remove
- skin/fonts/CreteRound-Italic.otf
- skin/fonts/CreteRound-Regular.otf
- skin/social/facebook.png
- skin/social/googleplus.png
- skin/social/renren.png
- skin/social/twitter.png
- skin/social/weibo.png
- skin/ajax-loader.gif
- skin/background-share.png
- skin/donate.png
- Rename
| From | To |
|---|---|
| locale/en_US/firstRun.json | locale/en_US/first-run.json |
| skin/fonts/Source-Sans-Pro/LICENSE.txt | LICENSE-3RD-PARTY.txt |
| skin/updates/appstore-bg.svg | skin/backgrounds/appstore.svg |
| skin/updates/googleplay-bg.svg | skin/backgrounds/googleplay.svg |
| skin/firstRun.css | skin/first-run.css |
| firstRun.html | first-run.html |
| firstRun.js | first-run.js |
Hints for testers
- Text that's meant for screen readers should not be visible in desktop options page:
- Close button for message that pops up when adding a new domain to the whitelist.
- Close button for message that pops up when both EasyPrivacy and Acceptable Ads are enabled.
- App Store and Play Store badges should be shown on updates page.
Attachments (0)
Change History (9)
comment:1 Changed on 06/18/2018 at 06:03:56 PM by greiner
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 06/19/2018 at 12:54:55 PM by greiner
- Description modified (diff)
Updated dependency update notes to reflect renaming of first-run page files.
comment:5 Changed on 07/05/2018 at 11:07:02 AM by greiner
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 Changed on 08/28/2018 at 12:26:11 PM by greiner
- Blocking 6892 added
comment:7 Changed on 08/28/2018 at 04:28:20 PM by greiner
- Description modified (diff)
Added hints for testers.
comment:8 Changed on 09/13/2018 at 10:30:23 AM by abpbot
Some commits referencing this issue have landed:
comment:9 Changed on 10/26/2018 at 10:19:17 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Could not find any major issues with the changes to the first run page.
ABP 3.3.2.2176
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10
Added notes for dependency update