Opened on 08/28/2018 at 11:46:16 AM
Closed on 09/13/2018 at 04:42:27 PM
Last modified on 10/26/2018 at 12:32:15 PM
#6892 closed change (fixed)
Update adblockplusui dependency to hg:7386698260f4 (release-2018-4)
Reported by: | greiner | Assignee: | greiner |
---|---|---|---|
Priority: | P2 | Milestone: | Adblock-Plus-3.4-for-Chrome-Opera-Firefox |
Module: | Platform | Keywords: | |
Cc: | wspee, sebastian, saroyanm | Blocked By: | #5851, #6171, #6633, #6659, #6712, #6736, #6740, #6742, #6749, #6751, #6758, #6759, #6760, #6768, #6779, #6788, #6792, #6794, #6795, #6800, #6801, #6816, #6818, #6827, #6828, #6838, #6846, #6846, #6852, #6864, #6878, #6895, #6896, #6898, #6903, #6911, #6922, #6933, #6935 |
Blocking: | Platform: | Unknown / Cross platform | |
Ready: | yes | Confidential: | no |
Tester: | Ross | Verified working: | yes |
Review URL(s): |
Description (last modified by greiner)
Background
This import the follow changes:
It also imports the following Noissue changes:
- Add 3rd parts license used by latest components
- Added Bubble UI Translations
- Added build directory to linting
- fixed breaking typo with the package
- Fixed: Added missing hit logger mocks
- Fixed: Build scripts were ignored by linter
- Fixed: ESLint didn't consider js directory
- Fixed: Popup icons rendered with button styles
- Fixed: prefer-const linting errors
- Fixed: Remember filter lists added by update attempt
- Implement IOScrollbar for infinite scroll
- package.json dependencies update
- Remove MR left over
- Removed unused issue-reporter.js
- Structured package.json
- update dependencies
- updated npm-dollar package
- use more readable CSV example in the README
What to change
- Change adblockplusui dependency to hg:7386698260f4 git:ab57a6b
- Apply necessary changes (see release-2018-4)
Hints for testers
Everything should be implemented according to the spec.
See also hints for testers section in the individual tickets.
Missing information
We're still waiting for translations before we can say which revision should be used.
Attachments (0)
Change History (66)
comment:1 Changed on 08/28/2018 at 11:53:22 AM by greiner
- Component changed from User-Interface to Platform
- Description modified (diff)
- Summary changed from Update adblockplusui dependency to TBD (release-2018-5) to Update adblockplusui dependency to TBD (release-2018-4)
comment:2 Changed on 08/28/2018 at 12:13:36 PM by greiner
- Blocked By 6633 added
comment:4 Changed on 08/28/2018 at 12:21:28 PM by greiner
- Blocked By 6659 added
comment:5 Changed on 08/28/2018 at 12:23:07 PM by greiner
- Blocked By 6633 removed
comment:6 Changed on 08/28/2018 at 12:23:16 PM by greiner
- Blocked By 6633 added
comment:8 Changed on 08/28/2018 at 12:24:34 PM by greiner
- Blocked By 6712 added
comment:9 Changed on 08/28/2018 at 12:25:16 PM by greiner
- Blocked By 6736 added
comment:10 Changed on 08/28/2018 at 12:25:48 PM by greiner
- Blocked By 6742 added
comment:11 Changed on 08/28/2018 at 12:26:11 PM by greiner
- Blocked By 6749 added
comment:12 Changed on 08/28/2018 at 12:26:35 PM by greiner
- Blocked By 6751 added
comment:13 Changed on 08/28/2018 at 12:26:59 PM by greiner
- Blocked By 6758 added
comment:14 Changed on 08/28/2018 at 12:27:19 PM by greiner
- Blocked By 6759 added
comment:15 Changed on 08/28/2018 at 12:27:34 PM by greiner
- Blocked By 6760 added
comment:16 Changed on 08/28/2018 at 12:27:54 PM by greiner
- Blocked By 6768 added
comment:17 Changed on 08/28/2018 at 12:28:20 PM by greiner
- Blocked By 6788 added
comment:18 Changed on 08/28/2018 at 12:28:53 PM by greiner
- Blocked By 6794 added
comment:19 Changed on 08/28/2018 at 12:29:12 PM by greiner
- Blocked By 6795 added
comment:20 Changed on 08/28/2018 at 12:29:45 PM by greiner
- Blocked By 6800 added
comment:21 Changed on 08/28/2018 at 12:30:08 PM by greiner
- Blocked By 6801 added
comment:22 Changed on 08/28/2018 at 12:30:27 PM by greiner
- Blocked By 6816 added
comment:23 Changed on 08/28/2018 at 12:30:40 PM by greiner
- Blocked By 6818 added
comment:24 Changed on 08/28/2018 at 12:30:55 PM by greiner
- Blocked By 6827 added
comment:25 Changed on 08/28/2018 at 12:31:12 PM by greiner
- Blocked By 6828 added
comment:26 Changed on 08/28/2018 at 12:31:39 PM by greiner
- Blocked By 6838 added
comment:27 Changed on 08/28/2018 at 12:32:31 PM by greiner
- Blocked By 6876 added
comment:28 Changed on 08/28/2018 at 12:33:55 PM by greiner
- Blocked By 6878 added
comment:29 Changed on 08/28/2018 at 12:41:25 PM by greiner
- Description modified (diff)
comment:30 Changed on 08/28/2018 at 01:22:36 PM by greiner
- Blocked By 6171 added
comment:31 Changed on 08/28/2018 at 01:24:00 PM by greiner
- Blocked By 6779 added
comment:32 Changed on 08/28/2018 at 01:26:34 PM by greiner
- Blocked By 6792 added
comment:33 Changed on 08/28/2018 at 01:28:35 PM by greiner
- Blocked By 6852 added
comment:34 Changed on 08/28/2018 at 01:29:25 PM by greiner
- Blocked By 6864 added
comment:35 Changed on 08/28/2018 at 01:33:50 PM by greiner
- Blocked By 6895 added
comment:36 Changed on 08/28/2018 at 02:00:32 PM by greiner
- Blocked By 6896 added
comment:37 Changed on 08/28/2018 at 02:17:25 PM by greiner
- Cc sebastian added
comment:38 Changed on 08/28/2018 at 03:04:32 PM by saroyanm
- Blocked By 6898 added
comment:39 Changed on 08/28/2018 at 04:24:27 PM by saroyanm
- Cc saroyanm added
comment:40 Changed on 08/28/2018 at 04:45:55 PM by greiner
- Description modified (diff)
comment:41 Changed on 08/29/2018 at 12:59:28 PM by saroyanm
- Blocked By 6903 added
comment:42 Changed on 08/29/2018 at 05:56:11 PM by greiner
- Blocked By 6907 added
comment:43 Changed on 09/03/2018 at 12:10:28 PM by greiner
- Blocked By 6921 added
comment:44 Changed on 09/04/2018 at 10:34:21 AM by agiammarchi
- Blocked By 6922 added
comment:45 Changed on 09/04/2018 at 05:53:06 PM by greiner
- Blocked By 6846 added
comment:46 Changed on 09/04/2018 at 06:22:25 PM by saroyanm
- Blocked By 6898 removed
comment:47 Changed on 09/04/2018 at 06:23:57 PM by saroyanm
- Blocked By 6898 added
comment:48 Changed on 09/06/2018 at 11:14:51 AM by greiner
- Blocked By 6933 added
comment:49 Changed on 09/06/2018 at 11:17:12 AM by greiner
- Blocked By 6907 removed
comment:50 Changed on 09/06/2018 at 11:17:21 AM by greiner
- Blocked By 6921 removed
comment:51 Changed on 09/06/2018 at 11:17:33 AM by greiner
- Blocked By 6876 removed
comment:52 Changed on 09/06/2018 at 05:26:51 PM by greiner
- Blocked By 5851 added
comment:53 Changed on 09/07/2018 at 12:56:07 PM by greiner
- Blocked By 6935 added
comment:54 Changed on 09/07/2018 at 04:01:22 PM by greiner
See also #6684.
comment:55 Changed on 09/07/2018 at 05:22:23 PM by greiner
See also #6321.
comment:56 Changed on 09/12/2018 at 02:44:07 PM by sebastian
- Priority changed from Unknown to P2
- Ready set
I just discussed with Winsley to perform this dependency update as soon as possible (without waiting any longer for the translations), and then have another dependency update once the translations are ready (latest in two weeks).
comment:57 Changed on 09/12/2018 at 03:09:46 PM by greiner
- Owner set to greiner
comment:58 Changed on 09/13/2018 at 10:33:58 AM by greiner
- Description modified (diff)
- Summary changed from Update adblockplusui dependency to TBD (release-2018-4) to Update adblockplusui dependency to hg:0a78a4efe4d5 (release-2018-4)
I've now pushed git:release-2018-4 to hg:master and added the corresponding hashes to the ticket.
comment:59 Changed on 09/13/2018 at 11:02:17 AM by greiner
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:60 Changed on 09/13/2018 at 04:04:33 PM by greiner
- Description modified (diff)
- Summary changed from Update adblockplusui dependency to hg:0a78a4efe4d5 (release-2018-4) to Update adblockplusui dependency to hg:7386698260f4 (release-2018-4)
Updated ticket to include preliminary translations, as was requested during review.
comment:61 Changed on 09/13/2018 at 04:40:01 PM by abpbot
A commit referencing this issue has landed:
Issue 6892 - Update adblockplusui dependency to hg:7386698260f4
comment:62 Changed on 09/13/2018 at 04:42:27 PM by greiner
- Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:63 Changed on 09/18/2018 at 10:03:52 AM by greiner
- Blocked By 6740 added
comment:64 Changed on 09/28/2018 at 01:17:49 PM by greiner
See also #6845.
comment:65 Changed on 10/10/2018 at 12:56:49 PM by greiner
- Blocked By 6911 added
comment:66 Changed on 10/26/2018 at 12:32:15 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Apart from the possible notification issues in #6922 this is fine.
ABP 3.3.2.2176
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10
Added hints for testers.