Opened on 07/04/2018 at 10:08:42 PM

Closed on 09/06/2018 at 03:31:52 PM

#6774 closed defect (fixed)

$document doesn't whitelist everything inside iframes in Edge

Reported by: oleksandr Assignee: geo
Priority: Unknown Milestone: Adblock-Plus-3.4-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: sebastian, geo, arthur Blocked By:
Blocking: Platform: Edge
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29832561/

Description (last modified by mapx)

Environment

ABP for Edge 0.9.11

How to reproduce

  1. Add this custom filter: @@^uponit=true$document
  2. Set up attached files in one directory
    • Load SafeFrame.html - a simple html file with a static ad.
    • Include_safeFrame.html is a simple HTML file that includes the first one with the parameter uponit=true while this rule exists:

@@^uponit=true$document

  1. Open Include_safeFrame.html in Edge.

Observed behaviour

The requests inside safeFrame.html are indeed white-listed, but the ad is hidden by a CSS selector, and the result is a blank ad.

Expected behaviour

The $document rule should white-list the entire iframe, but it seems that in Edge, only the requests are white-listed and the hide rules (CSS display important rules) are still there in those white-listed iframes when there is another iframe inside them.

This seems very much alike #6692, but is Edge specific.

Attachments (2)

include_safeFrame.html​ (75 bytes) - added by oleksandr on 07/09/2018 at 08:08:53 PM.
safeFrame.html​ (679 bytes) - added by oleksandr on 07/09/2018 at 08:09:03 PM.

Download all attachments as: .zip

Change History (10)

comment:1 Changed on 07/05/2018 at 06:27:59 AM by mapx

  • Description modified (diff)

comment:2 Changed on 07/05/2018 at 02:13:33 PM by sebastian

  • Cc sebastian geo added

Changed on 07/09/2018 at 08:08:53 PM by oleksandr

Changed on 07/09/2018 at 08:09:03 PM by oleksandr

comment:3 Changed on 07/10/2018 at 09:27:19 AM by arthur

  • Cc arthur added

comment:4 Changed on 07/12/2018 at 11:02:24 AM by geo

  • Owner set to geo

comment:5 Changed on 07/17/2018 at 01:19:27 PM by geo

  • Review URL(s) modified (diff)

For reproducing the bug, I recommend to serve the files from a local server, otherwise you run into CORS errors.

comment:6 Changed on 07/17/2018 at 03:12:09 PM by sebastian

  • Status changed from new to reviewing

comment:7 Changed on 07/20/2018 at 03:14:38 PM by abpbot

A commit referencing this issue has landed:
​Issue 6774 - $document doesn't whitelist everything inside iframes in Edge

comment:8 Changed on 09/06/2018 at 03:31:52 PM by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from geo.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.