Opened on 07/09/2018 at 01:18:29 PM
Closed on 12/05/2018 at 11:20:52 PM
#6778 closed defect (duplicate)
ABP for Edge fails on some test cases on testpages.adblockplus.org
| Reported by: | oleksandr | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Platform | Keywords: | |
| Cc: | sebastian, kzar, geo, hfiguiere | Blocked By: | |
| Blocking: | Platform: | Edge | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Environment
Development Build of ABP for Edge
How to reproduce
- Go to https://testpages.adblockplus.org and navigate in different test cases.
Observed behaviour
Test cases fail for:
- -abp-has()
- Chained extended selectors
- Regular expression in :-abp-contains()
Expected behaviour
Test cases at least for -abp-has() and Chained extended selectors should work.
Attachments (0)
Change History (8)
comment:1 Changed on 07/09/2018 at 01:20:10 PM by kzar
- Cc geo added
comment:2 Changed on 07/09/2018 at 02:52:51 PM by sebastian
- Cc hfiguiere added
comment:5 Changed on 07/09/2018 at 08:15:15 PM by oleksandr
No, I don't see any errors in the console. And I haven't really looked into the issue any deeper, unfortunately.
comment:6 Changed on 07/09/2018 at 09:11:01 PM by hfiguiere
If it is issue #6304, we catch the exception.
See lib/content/elemHideEmulation.js around line 163. There is an explicit catch to check the feature that Edge doesn't seem to have. Maybe this is the time it should be fixed.
comment:7 Changed on 07/09/2018 at 10:30:42 PM by sebastian
If it's really just about #6304 (and assuming there is no low-hanging fruit replacing the :scope pseudo-class?), we might want to just accept that limitation on Microsoft Edge for now. It's not the only limitation we have there, and it seems we currently have more pressing issues to tackle on Microsoft Edge. Also chances are that Microsoft Edge will support :scope in the future.
Hubert, any idea why emulated element hiding selectors might not (fully) work on Microsoft Edge?
Ollie, did you see any error logged to the console?