Opened on 07/11/2018 at 04:57:55 PM
Closed on 07/17/2018 at 02:37:50 PM
Last modified on 08/07/2018 at 08:21:53 AM
#6783 closed change (fixed)
Subscribe to and enable our anti-circumvention filter list for existing users
| Reported by: | hfiguiere | Assignee: | hfiguiere |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-3.3-for-Chrome-Opera-Firefox |
| Module: | Platform | Keywords: | circumvention |
| Cc: | mjethani, kzar, sebastian, arthur, mapx | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by hfiguiere)
Background
We're creating our own filter list (see Hub issue 11069) with the aim of tackling circumvention more effectively. We'd like the filter list to be enabled by default, with the hope that it will help our users.
With #6699 we've added support for multiple default filter lists, so that we can enable our filter list for new users. Now we'd like to ensure that existing users are given subscribed to our new filter list too.
What to change
- Subscribe to and enable our new anti-circumvention filter list when the extension first starts. But only if it's not already present and the subscriptions_addedanticv preference falsey.
- After subscribing to the filter list set the subscriptions_addedanticv preference to true.
Hint for testers
- Test that when a user upgrades from an earlier version, that our anti-circumvention filter list is added and enabled.
- Test that when a user then disables and/or removes our subscription, it isn't re-added the next time the extension starts.
- Test that the regular default subscription is added as normal.
- Test that the regular default subscription isn't re-added on upgrade at the same time the anti-circumvention filter subscription is added.
Attachments (0)
Change History (16)
comment:2 Changed on 07/11/2018 at 05:11:59 PM by hfiguiere
- Keywords circumvention added
comment:3 Changed on 07/11/2018 at 05:12:12 PM by hfiguiere
- Owner set to hfiguiere
comment:4 Changed on 07/11/2018 at 05:12:45 PM by hfiguiere
- Cc mjethani kzar sebastian added
comment:6 in reply to: ↑ 5 Changed on 07/11/2018 at 07:16:01 PM by hfiguiere
Replying to kzar:
Also please can you be more specific about the preference, e.g. what's it called?
I'll had that when I know :-)
comment:8 Changed on 07/11/2018 at 07:22:02 PM by hfiguiere
- Summary changed from Ensure upgrading are subscribed to the circumvention filter list. to Ensure users upgrading are subscribed to the anti-circumvention filter list.
comment:9 Changed on 07/12/2018 at 02:25:01 AM by hfiguiere
comment:10 Changed on 07/12/2018 at 07:18:09 AM by arthur
- Cc arthur added
comment:11 Changed on 07/12/2018 at 10:02:41 AM by kzar
- Cc mapx added
- Description modified (diff)
- Priority changed from Unknown to P2
- Ready set
- Summary changed from Ensure users upgrading are subscribed to the anti-circumvention filter list. to Subscribe to and enable our anti-circumvention filter list for existing users
Thanks for being more specific about the preference. I've updated the introduction for you.
comment:12 Changed on 07/16/2018 at 04:37:38 PM by kzar
- Description modified (diff)
comment:13 Changed on 07/17/2018 at 02:32:22 PM by hfiguiere
- Description modified (diff)
comment:14 Changed on 07/17/2018 at 02:34:40 PM by abpbot
A commit referencing this issue has landed:
Issue 6783 - opt-in to anti circumvention filter list on upgrade
comment:15 Changed on 07/17/2018 at 02:37:50 PM by hfiguiere
- Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:16 Changed on 08/07/2018 at 08:21:53 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Functioning as described.
ABP 3.2.2102
Chrome 66 / 55 / 49 / Windows 10
Firefox 61 / 55 / 51
Please can you add a bit more of an introduction? Also please can you be more specific about the preference, e.g. what's it called?