Opened on 07/20/2018 at 12:57:40 PM
Closed on 08/01/2018 at 06:37:50 AM
#6799 closed defect (fixed)
Hebrew subscription is not installed for Hebrew locale
| Reported by: | asmirnov | Assignee: | |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Libadblockplus-Android | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Android | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29835555/ |
||
Description
Environment
We pass default android locale (modified) to libadblockplus and it passes it to core to choose subscriptions on the very first launch.
https://github.com/adblockplus/libadblockplus-android/blob/master/adblock-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java#L84
Hebrew subscriptions is expected to be installed for android device if Hebrew is set as Default locale but regular easylist subscription is sinstalled instead.
How to reproduce
- Set Hebrew as default android device locale.
- Run AdblockWebView demo app
- Navigate to any URL
- Make sure you can see regular easylist subscription URL is used (android logcat).
...
Observed behaviour
regular easylist subscription URL is used (android logcat)
Expected behaviour
Hebrew easylist subscription URL is used (android logcat).
Attachments (0)
Change History (11)
comment:1 Changed on 07/20/2018 at 12:59:25 PM by asmirnov
comment:2 Changed on 07/20/2018 at 01:01:24 PM by asmirnov
It's expected to have he as country code: in our subscriptions configuration:
https://github.com/adblockplus/adblockpluscore/blob/master/chrome/content/ui/subscriptions.xml#L77
comment:3 Changed on 07/20/2018 at 01:02:10 PM by asmirnov
It's expected to be he by ISO:
http://www.loc.gov/standards/iso639-2/php/code_list.php
comment:4 Changed on 07/20/2018 at 01:14:44 PM by asmirnov
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 07/20/2018 at 01:29:59 PM by asmirnov
comment:6 Changed on 07/23/2018 at 04:02:31 PM by abpbot
A commit referencing this issue has landed:
Issue 6799 - Hebrew subscription is not installed for Hebrew locale
comment:7 Changed on 07/23/2018 at 04:03:04 PM by asmirnov
- Resolution set to fixed
- Status changed from reviewing to closed
comment:8 Changed on 07/30/2018 at 12:25:08 PM by asmirnov
- Resolution fixed deleted
- Status changed from closed to reopened
comment:10 Changed on 08/01/2018 at 05:57:04 AM by abpbot
A commit referencing this issue has landed:
Issue 6799 - Hebrew subscription is not installed for Hebrew locale
comment:11 Changed on 08/01/2018 at 06:37:50 AM by asmirnov
- Resolution set to fixed
- Status changed from reopened to closed
Published version 3.1:
https://bintray.com/adblockplus/maven/adblock-android/3.1
https://wiki.mozilla.org/L10n:Locale_Codes is used:
https://github.com/adblockplus/libadblockplus/blob/master/include/AdblockPlus/AppInfo.h#L53