Opened on 07/20/2018 at 03:09:32 PM
Closed on 07/27/2018 at 11:48:36 AM
Last modified on 08/16/2018 at 01:17:56 PM
#6802 closed change (fixed)
Update adblockplusui dependency to 3b97a00a1189
| Reported by: | greiner | Assignee: | |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-3.3-for-Chrome-Opera-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | sebastian, kzar, wspee, hfiguiere, mjethani, saroyanm, Ross, rscott | Blocked By: | #6784 |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by kzar)
Background
In #6784 we are going to introduce an anti-circumvention filter list for which we have created a basic UI to go along with it. Therefore we should update the adblockplusui dependency to include that UI in that same release as soon as we got the translations for its strings.
What to change
Update the adblockplusui dependency to hg:3b97a00a1189 git:e4c4803.
| Ticket | Summary | Component |
|---|---|---|
| #6731 | Handle anti-circumvention list in UI | User-Interface |
Hints for testers
- Ensure that the "ABP Anti-Circumvention Filter List" is added into the "ANTI-CIRCUMVENTION" section of the general tab of the options page.
- If "ABP Anti-Circumvention Filter List" is checked, the subscription list should have the "ABP Filters" list (Advanced tab)
- Removing the "ABP Filters" entry in the subscription list (Advanced tab) should make "ABP Anti-Circumvention Filter List" unchecked.
For more details about how it should behave see the specification in GitLab.
Attachments (0)
Change History (14)
comment:1 Changed on 07/24/2018 at 01:27:55 PM by hfiguiere
- Cc hfiguiere added
comment:2 Changed on 07/24/2018 at 04:01:53 PM by mjethani
- Cc mjethani added
comment:3 Changed on 07/27/2018 at 10:57:55 AM by saroyanm
- Cc saroyanm added
- Description modified (diff)
- Summary changed from Update adblockplusui dependency to TBA to Update adblockplusui dependency to 3b97a00a1189
comment:4 Changed on 07/27/2018 at 10:59:05 AM by saroyanm
- Description modified (diff)
Removed missing information section
comment:5 follow-up: ↓ 7 Changed on 07/27/2018 at 11:06:38 AM by kzar
- Cc Ross rscott added
- Description modified (diff)
- Priority changed from Unknown to P1
Please can you add a hints for testers section, which explains how the UI relating to the circumvention filter should function with this change?
comment:6 Changed on 07/27/2018 at 11:10:00 AM by saroyanm
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:7 in reply to: ↑ 5 Changed on 07/27/2018 at 11:12:12 AM by saroyanm
Replying to kzar:
Please can you add a hints for testers section, which explains how the UI relating to the circumvention filter should function with this change?
Good point.
@greiner and/or @hfiguiere probably knows better(if there are worth notting details for testers), as they were working on the implementation AFAIK, if they don't take that over, I'll check the details and add the section accordingly.
comment:8 Changed on 07/27/2018 at 11:32:28 AM by saroyanm
- Description modified (diff)
Added"Hints for testers".
comment:10 Changed on 07/27/2018 at 11:47:31 AM by abpbot
A commit referencing this issue has landed:
Issue 6802 - Update adblockplusui dependency to 3b97a00a1189
comment:11 Changed on 07/27/2018 at 11:48:36 AM by saroyanm
- Resolution set to fixed
- Status changed from reviewing to closed
comment:12 Changed on 07/27/2018 at 12:43:31 PM by hfiguiere
- Description modified (diff)
comment:13 Changed on 07/27/2018 at 01:10:05 PM by kzar
- Description modified (diff)
Thanks for adding those details Hubert.
comment:14 Changed on 08/16/2018 at 01:17:56 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Circumvention list UI elements behave as described.
ABP 3.2.0.2103
Chrome 68 / 55 / 49 / Windows 10
Firefox 61 / 55 / 51 / Windows 10
Updated the ticket with hashes, I think this ticket can be marked as ready.