Opened on 07/24/2018 at 06:51:41 PM

Closed on 07/24/2018 at 07:30:55 PM

Last modified on 08/21/2018 at 11:27:09 AM

#6807 closed change (fixed)

Update adblockpluscore dependency to hg:056695656851

Reported by: mjethani Assignee: mjethani
Priority: P2 Milestone: Adblock-Plus-3.3-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: kzar, sebastian, hfiguiere Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

​https://codereview.adblockplus.org/29837566/

Description (last modified by mjethani)

Background

After the last dependency update (#6784), we have fixed a bug in element hiding emulation (#6680) and added a couple of snippets (#6790, #6803).

What to change

Update the adblockpluscore dependency in the dependencies file to hg:056695656851 git:4d8b7fe.

Hints for testers

Please see #6680, #6790, and #6803.

Attachments (0)

Change History (8)

comment:1 Changed on 07/24/2018 at 06:52:41 PM by mjethani

  • Cc kzar sebastian hfiguiere added

comment:2 Changed on 07/24/2018 at 06:57:13 PM by mjethani

  • Owner set to mjethani
  • Review URL(s) modified (diff)

comment:3 Changed on 07/24/2018 at 06:57:19 PM by mjethani

  • Status changed from new to reviewing

comment:4 Changed on 07/24/2018 at 07:06:10 PM by mjethani

  • Description modified (diff)

comment:5 Changed on 07/24/2018 at 07:18:28 PM by kzar

  • Priority changed from Unknown to P2
  • Ready set

comment:6 Changed on 07/24/2018 at 07:29:27 PM by abpbot

A commit referencing this issue has landed:
​Issue 6807 - Update adblockpluscore dependency to hg:056695656851

comment:7 Changed on 07/24/2018 at 07:30:55 PM by mjethani

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed on 08/21/2018 at 11:27:09 AM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

The two snippets are working as expected. I haven't succesfully tested #6680 yet but will do.

ABP 3.2.0.2103
Chrome 68 / 55 / 49 / Windows 10
Firefox 61 / 55 / 51 / Windows 10

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from mjethani.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.