Opened on 08/02/2018 at 08:05:50 PM
Closed on 08/02/2018 at 11:21:10 PM
Last modified on 08/07/2018 at 03:44:50 PM
#6832 closed defect (fixed)
EasyList is not reinstalled if removed
| Reported by: | Ross | Assignee: | hfiguiere |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-3.3-for-Chrome-Opera-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | sebastian, kzar, hfiguiere | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Environment
ABP 3.2.2101
Chrome 49 / 55 / Windows 10
Firefox 61 / Windows 10
Does not occur in release 3.2
How to reproduce
- Install ABP.
- Open ABP options.
- In Advanced tab, remove EasyList via trashcan.
- Restart browser.
Observed behaviour
EasyList has not been reinstalled.
Expected behaviour
EasyList should be reinstalled.
Note
The other behaviour similar to this, where the first run page is opened with a warning and all default filter lists are re-installed if all filter lists have been removed seems to be working as expected. This only occurs when just EasyList is removed.
Attachments (0)
Change History (12)
comment:1 Changed on 08/02/2018 at 08:07:19 PM by Ross
comment:2 Changed on 08/02/2018 at 08:54:25 PM by sebastian
That makes sense. The logic is to reinitialize filter lists if there is no custom filters and no subscriptions other than Acceptable Ads and the Adblock Warning Removal List. So previously removing EasyList was sufficient to trigger this condition. But now there is also the "ABP filters" list, which we might want to add to the list.
comment:3 Changed on 08/02/2018 at 08:57:00 PM by sebastian
- Cc hfiguiere added
comment:4 Changed on 08/02/2018 at 10:32:37 PM by hfiguiere
- Owner set to hfiguiere
comment:5 Changed on 08/02/2018 at 10:33:41 PM by hfiguiere
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 08/02/2018 at 10:34:14 PM by hfiguiere
- Component changed from Unknown to Adblock-Plus-for-Chromium
comment:7 Changed on 08/02/2018 at 10:58:15 PM by hfiguiere
- Component changed from Adblock-Plus-for-Chromium to Platform
comment:8 Changed on 08/02/2018 at 11:20:18 PM by abpbot
A commit referencing this issue has landed:
Issue 6832 - Easylist was not re-added if the anti-circumvention list existed
comment:9 Changed on 08/02/2018 at 11:21:10 PM by hfiguiere
- Milestone set to Adblock-Plus-3.3-for-Chrome-Opera-Firefox
- Resolution set to fixed
- Status changed from reviewing to closed
comment:10 Changed on 08/03/2018 at 10:07:45 AM by Ross
- Ready set
- Tester changed from Unknown to Ross
Fixed.
ABP 3.2.2102
Chrome 68 / 55 / 49 / Windows 10
Firefox 61 / 51 / Windows 10
comment:11 Changed on 08/03/2018 at 03:26:38 PM by kzar
- Priority changed from Unknown to P1
comment:12 Changed on 08/07/2018 at 03:44:50 PM by Ross
- Ready unset
- Verified working set
This one is perplexing me as I thought I'd already tested this and it was working fine. I thought it might be caused by the new build (.2101) but can also reproduce it now with the build where I thought this was fine (.2097).