Opened on 08/06/2018 at 01:19:00 PM

Closed on 08/31/2018 at 04:32:24 PM

#6835 closed change (fixed)

Add R support to python-abp

Reported by: atudor Assignee: atudor
Priority: Unknown Milestone:
Module: Sitescripts Keywords:
Cc: kvas, Kirill Blocked By:
Blocking: #6216 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29849585/

Description

Background

The data team uses the python-abp module to parse filters.

The old (experimental) version of the module provides support for the API to be used from R, through the rpy.py file. In the current GitHub repository, however, this file is not present, thus breaking the compatibility with R.

Original implementation: https://bitbucket.org/kvas/python-abp
Current repository: https://github.com/adblockplus/python-abp

To Do

1) Include the rpy.py file in the current repository
2) Implement all the required extra functionality in order for the module to be fully compatible with R.

Attachments (0)

Change History (5)

comment:1 Changed on 08/06/2018 at 01:19:23 PM by atudor

  • Type changed from defect to change

comment:2 Changed on 08/07/2018 at 03:21:14 PM by atudor

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 08/20/2018 at 03:04:49 PM by atudor

  • Blocking 6216 added

comment:4 Changed on 08/31/2018 at 02:32:01 PM by abpbot

A commit referencing this issue has landed:
Issue 6835 - Add R support to python-abp

comment:5 Changed on 08/31/2018 at 04:32:24 PM by atudor

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from atudor.
 
Note: See TracTickets for help on using tickets.