Errors in console in Firefox 55, 51

[Ross]

Environment

ABP 3.2.2102
Firefox 51 / 55 / Windows 10

Could not reproduce in Firefox 61 or any Chrome version.

How to reproduce

1. Install ABP.
2. Open ABP options page.
3. Open Firefox Console (CTRL+SHIFT+J).

Observed behaviour

The following errors are displayed in the console:

port is undefined  adblockplus.js:7521

RangeError: invalid language tag: en_US  desktop-options.js:56:10

Expected behaviour

No errors to occur.

[kzar]

I can't reproduce that "port is undefined" exception on Firefox 52.9.0 ESR, but I can reproduce the other one and some more too:

ReferenceError: reference to undefined property "tagName"[Learn More]  desktop-options.js:339:1
ReferenceError: reference to undefined property "emptyTexts"[Learn More]  desktop-options.js:77:11
RangeError: invalid language tag: en_GB  desktop-options.js:56:10
ReferenceError: reference to undefined property "url"[Learn More]  desktop-options.js:252:1
ReferenceError: reference to undefined property "url"[Learn More]  desktop-options.js:114:1

That said I can also reproduce those on Adblock Plus 3.2, so it doesn't seem to be regression since the previous release.

Apart from the exceptions in the console, does the options work OK for you on those earlier versions of Firefox?

It's not clear yet if this is a UI or Platform issue, but I'll assume the latter and triage for now...

[greiner]

I'm not sure yet either whether or not those are UI issues so I'll have to investigate further.

At least the language tag issue seems quite straight-forward because we're expecting a locale string of the format "en-GB" but - using Utils.appLocale - are getting "en_GB" back by browser.i18n.getUILanguage() which shouldn't be the case ​according to MDN.

[greiner]

Using Adblock Plus 3.2 with Firefox 52 ESR on Ubuntu 18.04 I didn't get any of those errors but instead:

In add-on {d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}, attempting to use listener "tabs.onReplaced", which is unimplemented.  ExtensionParent.jsm:524:71
In add-on {d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}, attempting to use listener "notifications.onButtonClicked", which is unimplemented.  ExtensionParent.jsm:524:71

According to MDN neither of those APIs is supported by Firefox though.

[sebastian]

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the ​new issue tracker.