Opened on 08/15/2018 at 02:47:54 PM
Closed on 08/30/2018 at 05:47:15 PM
Last modified on 10/24/2018 at 01:41:48 PM
#6862 closed change (fixed)
Make Snippets module emit events
| Reported by: | mjethani | Assignee: | mjethani |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Core | Keywords: | circumvention |
| Cc: | kzar | Blocked By: | |
| Blocking: | #6538, #6826 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): |
https://codereview.adblockplus.org/29856564/ |
||
Description (last modified by mjethani)
Background
For #6826, the Snippets module will have to notify any listeners when a new filter is added or an existing one removed (see patch #29856567).
What to change
Make the Snippets module in lib/snippets.js emit events for the addition, removal, and clearing of filters.
Hints for testers
Make sure that snippet filters are working in general.
Attachments (0)
Change History (8)
comment:1 Changed on 08/15/2018 at 02:53:52 PM by mjethani
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 08/15/2018 at 02:54:58 PM by mjethani
- Blocking 6826 added
comment:3 Changed on 08/29/2018 at 05:56:03 PM by abpbot
comment:5 Changed on 08/30/2018 at 05:46:09 PM by abpbot
A commit referencing this issue has landed:
Issue 6862 - Add tests for Snippets module events
comment:6 Changed on 08/30/2018 at 05:47:15 PM by mjethani
- Resolution set to fixed
- Status changed from reviewing to closed
comment:8 Changed on 10/24/2018 at 01:41:48 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Snippets appear to be working in general.
ABP 3.3.2.2175
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10
A commit referencing this issue has landed:
Issue 6862 - Make Snippets module emit events