Opened on 08/16/2018 at 12:34:26 PM
Closed on 03/28/2019 at 11:47:27 AM
#6865 closed change (fixed)
Update ABP dependency to version 3.2
| Reported by: | diegocarloslima | Assignee: | diegocarloslima |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Browser-for-Android-1.5.0 |
| Module: | Adblock-Browser-for-Android | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Adblock Browser for Android | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by diegocarloslima)
Background
Since we're merging Firefox 59, we need to change our ABP dependency to the WebExtension one in order to keep the adblocking functionality working in Adblock Browser.
This dependency update breaks the whole communication between the extension and the Android part, because the WebExtension APIs are much more restrictive and doesn't allow us to use the Mozilla Messaging module. We'll need to adjust our code in order to make the communication possible again.
Hints for testers
Since we're shifting from the old Mozilla add-on to a WebExtension, we need to make sure that all the adblocking functionalities still work and also check for migration issues from previous versions.
Attachments (0)
Change History (8)
comment:1 Changed on 08/27/2018 at 07:08:10 PM by diegocarloslima
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 01/21/2019 at 12:00:20 PM by abpbot
comment:4 Changed on 01/21/2019 at 12:01:16 PM by diegocarloslima
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 03/18/2019 at 07:45:50 PM by aboegler
Diego: when upgrading from 1.4.0 to the current build of 1.5.0, all ad blocking settings are lost. This includes filter lists (languages and extra), whitelisted sites, and Acceptable Ads setting.
Steps to reproduce
- Install version 1.4.0 from the Play Store
- Launch ABB, and go to three-dots menu > Settings > Ad blocking
- Subscribe to some filter lists under "Languages" and "More blocking options"
- Add a domain under "Whitelisted websites"
- Tap "Acceptable Ads" and deselect the checkbox
- Quit ABB
- Install version 1.5.0
Expected result
The same filter lists are enabled as prior to the upgrade, the whitelisted domain is still whitelisted, and Acceptable Ads setting is disabled.
Actual result
Only the English filter list is enabled, the whitelisted sites list is empty, and Acceptable Ads are enabled again.
comment:6 Changed on 03/19/2019 at 12:23:31 PM by aboegler
- Resolution fixed deleted
- Status changed from closed to reopened
comment:7 Changed on 03/28/2019 at 11:44:05 AM by diegocarloslima
The issue found was moved to #7415, since it needs a separate fix
comment:8 Changed on 03/28/2019 at 11:47:27 AM by diegocarloslima
- Resolution set to fixed
- Status changed from reopened to closed
A commit referencing this issue has landed:
Issue 6865 - Update ABP dependency to version 3.2