Opened on 08/16/2018 at 06:36:43 PM

Closed on 08/17/2018 at 05:22:09 PM

#6867 closed defect (fixed)

Static generation test fails for expected_out/en/relpath

Reported by: jsonesen Assignee: jsonesen
Priority: P3 Milestone:
Module: Unknown Keywords: cms
Cc: rhowell, kvas Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29857615

Description (last modified by jsonesen)

How to reproduce

Clone CMS or update and run tox

Observed behaviour

Test fails for the rel_path expected output. This is due to the mock not working properly.

Expected behaviour

Test should pass.

Notes

Rosie reported this to me yesterday I was the one who committed the mock patch Looks like the most recent pytest update has caused a regression with the pytest mock.

What to change

Try removing the pytest-mock module and instead use the mock api

Attachments (0)

Change History (4)

comment:1 Changed on 08/16/2018 at 06:50:14 PM by jsonesen

  • Description modified (diff)

comment:2 Changed on 08/16/2018 at 07:39:43 PM by jsonesen

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 08/17/2018 at 05:19:50 PM by abpbot

A commit referencing this issue has landed:
​Issue 6867 - Fix pytest 3.7.1 mock regression

comment:4 Changed on 08/17/2018 at 05:22:09 PM by jsonesen

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from jsonesen.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.