Opened on 09/10/2018 at 10:46:13 AM
Closed on 09/26/2018 at 02:53:57 PM
Last modified on 10/17/2018 at 12:46:42 PM
#6938 closed defect (fixed)
The hide-if-contains-and-matches-style snippet does not work on Firefox
| Reported by: | Ross | Assignee: | mjethani |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Core | Keywords: | circumvention |
| Cc: | sebastian, mjethani, amrmak | Blocked By: | |
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by mjethani)
Environment
ABP 3.3.1.2125
Firefox 61 / 55 / Windows 10
How to reproduce
- Add the snippet and apply it to the example in #6919.
Observed behaviour
The snippet appears to have no effect in Firefox. It works in Chrome.
Expected behaviour
The snippet to work as described in #6919.
Additional notes
The fourth and fifth parameters of the snippet in particular do not match anything, because the snippet uses the cssText property which is always blank on Firefox due to Firefox bug #137687 (see discussion about Chrome vs. Firefox).
Hints for testers
The hide-if-contains-and-matches-style snippet should work exactly as described in #6919, but on both Chrome and Firefox.
Attachments (0)
Change History (9)
comment:1 Changed on 09/10/2018 at 11:26:58 AM by mjethani
- Description modified (diff)
- Priority changed from Unknown to P3
- Ready set
comment:2 Changed on 09/10/2018 at 05:33:20 PM by mjethani
- Sensitive unset
comment:3 Changed on 09/25/2018 at 07:00:28 PM by hfiguiere
comment:4 Changed on 09/25/2018 at 07:19:59 PM by mjethani
Yeah, it's not exactly a "bug", because it's the expected behavior now. It was a bit of oversight on my part not to take this into account when I wrote the snippet. Nevertheless, we can work around it and develop a more standards-compliant version of the snippet in the future.
comment:5 Changed on 09/26/2018 at 02:51:27 PM by abpbot
A commit referencing this issue has landed:
Issue 6938 - Port hide-if-contains-and-matches-style snippet to Firefox
comment:6 Changed on 09/26/2018 at 02:52:48 PM by mjethani
- Owner set to mjethani
- Review URL(s) modified (diff)
comment:7 Changed on 09/26/2018 at 02:53:57 PM by mjethani
- Description modified (diff)
- Resolution set to fixed
- Status changed from new to closed
comment:8 Changed on 09/29/2018 at 12:32:19 AM by abpbot
A commit referencing this issue has landed:
Issue 6938 - Port hide-if-contains-and-matches-style snippet to Firefox
comment:9 Changed on 10/17/2018 at 12:46:42 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Fixed. Snippet now works on Firefox, still works in Chrome/Opera.
ABP 3.3.2.2175
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10
a 17 year old Firefox bug...