Running npm test fails on Windows for adblockpluschrome

[geo]

Environment

Windows 10
revision: git f2d0c16 hg e7abbf2e9d9b
nodejs: v8.11.3

How to reproduce

1. Run npm install from PowerShell
2. Run npm test from PowerShell

Observed behaviour

The script throws the following errors:

1) chrome
       "before all" hook:
     Error: The ChromeDriver could not be found on the current PATH. Please download the latest version of the ChromeDriver from http://chromedriver.storage.googleapis.com/index.html and ensure it can be found on your PATH.
      at new ServiceBuilder (node_modules\selenium-webdriver\chrome.js:215:13)
      at getDefaultService (node_modules\selenium-webdriver\chrome.js:304:22)
      at Function.createSession (node_modules\selenium-webdriver\chrome.js:752:44)
      at createDriver (node_modules\selenium-webdriver\index.js:170:33)
      at Builder.build (node_modules\selenium-webdriver\index.js:642:16)
      at Object.exports.getDriver (test\browsers\chromium.js:49:6)
      at Promise.all.then (test\all.js:53:30)
      at <anonymous>
      at process._tickCallback (internal/process/next_tick.js:188:7)

  2) chrome
       "after all" hook:
     TypeError: Cannot read property 'quit' of undefined
      at Context.<anonymous> (test\all.js:80:19)

  3) gecko
       "before all" hook:
     Error: The geckodriver.exe executable could not be found on the current PATH. Please download the latest version from https://github.com/mozilla/geckodriver/releases/ and ensure it can be found on your PATH.
      at findGeckoDriver (node_modules\selenium-webdriver\firefox\index.js:354:11)
      at new ServiceBuilder (node_modules\selenium-webdriver\firefox\index.js:446:22)
      at Function.createSession (node_modules\selenium-webdriver\firefox\index.js:516:21)
      at createDriver (node_modules\selenium-webdriver\index.js:170:33)
      at Builder.build (node_modules\selenium-webdriver\index.js:645:16)
      at Object.exports.getDriver (test\browsers\firefox.js:43:6)
      at Promise.all.then (test\all.js:53:30)
      at <anonymous>
      at process._tickCallback (internal/process/next_tick.js:188:7)

  4) gecko
       "after all" hook:
     TypeError: Cannot read property 'quit' of undefined
      at Context.<anonymous> (test\all.js:80:19)
npm ERR! code ELIFECYCLE
npm ERR! errno 4
npm ERR! adblockpluschrome@ test-only: `mocha`
npm ERR! Exit status 4
npm ERR!
npm ERR! Failed at the adblockpluschrome@ test-only script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

Expected behaviour

The script should run without errors.

[sebastian]

Ross, this varies from the error you got last time. Can you try again, and let us know if you get the same error now, or which error you get instead (as of current master)?

[abpbot]

A commit referencing this issue has landed:
​Issue 6985 - Running npm test fails on Windows for adblockpluschrome

[Ross]

Fixed. Now working for both Chrome and Firefox on Windows. Thanks!

[takken3]

spam

[whiteson]

spam

[moffu]

spam