Opened on 09/26/2018 at 09:22:08 PM
Closed on 08/29/2019 at 05:43:52 PM
#6991 closed change (rejected)
Stop normalizing domain arguments in filter classes
| Reported by: | mjethani | Assignee: | mjethani |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Core | Keywords: | closed-in-favor-of-gitlab |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
In the isActiveOnDomain method of each ActiveFilter object, the parameter docDomain is lowercased and any trailing dots are removed. This is done for each filter. Most of the time, the caller either already has a lowercased domain with no trailing dot, or can do this transformation once on its own (calling isActiveOnDomain on each filter in a subscription, for example).
If this transformation is removed from the implementation of the function, it significantly improves the performance.
What to change
Remove the lowercasing and removal of any trailing dots from the implementation of isActiveOnDomain. Make sure callers are doing this on their own. Update the tests.
Attachments (0)
Change History (4)
comment:1 Changed on 09/26/2018 at 09:44:08 PM by mjethani
- Summary changed from Stop lowercasing and removing trailing dots in isActiveOnDomain to Stop lowercasing and removing trailing dots domain in filter classes
comment:2 Changed on 09/26/2018 at 09:44:51 PM by mjethani
- Summary changed from Stop lowercasing and removing trailing dots domain in filter classes to Stop normalizing domain arguments in filter classes
comment:3 Changed on 09/26/2018 at 10:32:48 PM by mjethani
- Ready unset
comment:4 Changed on 08/29/2019 at 05:43:52 PM by sebastian
- Keywords closed-in-favor-of-gitlab added
- Resolution set to rejected
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.