Opened on 06/24/2014 at 10:04:02 AM

Closed on 07/20/2015 at 02:22:14 PM

#701 closed defect (fixed)

firefox' issue reporter openes report URL instead of showing context menu when right-clicking

Reported by: philll Assignee: trev
Priority: P3 Milestone: Adblock-Plus-2.6.10-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29322658/

Description (last modified by trev)

Environment

Firefox ESR 24.5
ABP 2.6.3.3836

How to reproduce

  1. Open any website
  2. Click the ABP icon
  3. Click "Report issue on this page"
  4. Select "Adblock Plus does not block..."
  5. Click the "Next" button
  6. Click the "Send report" button
  7. Right click the URL of the report

Observed behaviour

The report is opened in a new tab.

Expected behaviour

The click should be ignored.

Attachments (0)

Change History (6)

comment:1 Changed on 06/24/2014 at 10:04:12 AM by philll

  • Priority changed from Unknown to P3

comment:2 Changed on 07/09/2014 at 06:46:41 AM by saroyanm

  • Platform set to Unknown

I think we will need to create our own context menu for that purpose.
Not sure if we can use the context menu that Firefox using in it's web content.

comment:3 Changed on 07/09/2014 at 12:38:11 PM by philll

  • Platform changed from Unknown to Firefox

comment:4 Changed on 07/20/2015 at 12:34:43 PM by trev

  • Owner set to trev
  • Tester set to Unknown

comment:5 Changed on 07/20/2015 at 12:35:49 PM by trev

  • Description modified (diff)
  • Review URL(s) modified (diff)

I think that displaying a context menu would go too far, we should simply ignore middle- and right-clicks - we already do it like that for the list of previously submitted reports.

Last edited on 07/20/2015 at 12:36:24 PM by trev

comment:6 Changed on 07/20/2015 at 02:22:14 PM by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from new to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
 
Note: See TracTickets for help on using tickets.