Opened on 10/08/2018 at 12:39:39 PM
Closed on 10/29/2018 at 10:42:29 PM
Last modified on 10/08/2019 at 06:06:05 PM
#7024 closed defect (fixed)
ManifoldJS fails to package Adblock Plus for Edge
Reported by: | tlucas | Assignee: | sebastian |
---|---|---|---|
Priority: | P2 | Milestone: | Adblock-Plus-3.4-for-Chrome-Opera-Firefox |
Module: | Automation | Keywords: | |
Cc: | sebastian, kzar, oleksandr, geo | Blocked By: | |
Blocking: | Platform: | Unknown / Cross platform | |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description
Environment
adblockpluschrome@ current master
How to reproduce
- make sure to have tox installed
- In the subdirectory to ./buildtools > invoke $ tox
- In the root directory > $ python build.py build -t edge
Observed behaviour
Step 2 succeeds with no errors (this tells us, that ManifoldJS is finishing successfully with a minified dummy extension)
Step 3 fails with the error message:
[error] manifoldjs : Failed to package the Microsoft Edge Extension Platform app. Failed to create the package. The CloudAppX service returned an error - Internal Server Error (500): APPX package generation failed. Error: Command failed: [error] manifoldjs : One or more platforms could not be generated successfully. For more information, run manifoldjs with the diagnostics level set to debug (e.g. manifoldjs [...] -l debug)
Expected behaviour
Both steps should succeed, no error message should be shown, step 3 should create a file adblockplusedge-v.v.v.v.appx in the root folder.
Additional Information
There is a thread @ github, leading to the conclusion that the webservice ManifoldJS uses to process a package refuses extensions, which have a larger total size than 1MB.
@snoack reached out to our contacts at Microsoft, to see if they can sort things out on their end. Until we know more about this, this issue must not be triaged.
Attachments (0)
Change History (10)
comment:1 Changed on 10/08/2018 at 01:42:46 PM by sebastian
comment:2 Changed on 10/29/2018 at 10:24:17 PM by sebastian
- Owner set to sebastian
comment:3 Changed on 10/29/2018 at 10:26:11 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 10/29/2018 at 10:33:08 PM by sebastian
- Priority changed from Unknown to P2
- Ready set
It turned out to have nothing to do with the size of the package after all, but rather with some obscure issue triggered by the presence of name_devbuild in _locales/az/messages.json.
comment:5 Changed on 10/29/2018 at 10:37:11 PM by abpbot
A commit referencing this issue has landed:
Issue 7024 - Renamed az translation to at-latn in Microsoft Edge builds
comment:6 Changed on 10/29/2018 at 10:41:39 PM by abpbot
A commit referencing this issue has landed:
Issue 7024 - Updated buildtools dependency for fixed Microsoft Edge builds
comment:7 Changed on 10/29/2018 at 10:42:29 PM by sebastian
- Milestone set to Adblock-Plus-3.4-for-Chrome-Opera-Firefox
- Resolution set to fixed
- Status changed from reviewing to closed
comment:8 Changed on 03/20/2019 at 06:37:42 AM by Thanos
spam
comment:9 Changed on 04/03/2019 at 02:39:35 PM by RobertAustwick
spam
comment:10 Changed on 05/16/2019 at 07:17:55 AM by Himanshu0709
spam
Assuming this is related to the size, any chance we can minimize the size of our builds? Some ideas:
FWIW, we don't know the exact size limit that triggers that issue. From the discussion on GitHub, it seems the largest extension known to build fine is 879KB, and a bunch of people who have the same issue as us, merely state that their extension is larger than 1MB (ABP is currently about 5MB uncompressed).
A smaller build size would be beneficial regardless of this issue, as it reduces disk space (to store older builds) and decreases bandwidth usage for updates.