Opened on 10/08/2018 at 06:05:36 PM
Closed on 11/20/2018 at 01:20:09 PM
Last modified on 02/14/2019 at 03:24:30 PM
#7027 closed change (fixed)
Adapt code to work with latest changes to FilterStorage.subscriptions
| Reported by: | greiner | Assignee: | greiner |
|---|---|---|---|
| Priority: | P1 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #7054 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): |
https://codereview.adblockplus.org/29907592/ |
||
Description (last modified by greiner)
Background
See https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/219
What to change
See https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/219
Hints for testers
- Adding filters through Block element dialog should not fail.
- Saving custom filters in desktop options page should add filters the user entered and remove filters the user deleted from the text area.
- Filter lists should be correctly displayed in desktop options page, mobile options page and issue report data.
- Disabled filters within filter should should be listed in the issue report using the "disabledFilters" property in the issue report data.
Attachments (0)
Change History (14)
comment:1 Changed on 10/08/2018 at 06:07:32 PM by greiner
- Owner set to greiner
comment:5 Changed on 10/17/2018 at 08:40:33 AM by greiner
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 10/17/2018 at 08:42:49 AM by greiner
- Blocking 7054 added
comment:7 Changed on 10/22/2018 at 07:56:04 AM by greiner
- Resolution set to fixed
- Status changed from reviewing to closed
comment:8 Changed on 10/22/2018 at 08:00:52 AM by abpbot
A commit referencing this issue has landed:
Issue 7027 - Adapted code to work with latest changes to FilterStorage.subscriptions
comment:9 Changed on 10/22/2018 at 07:17:08 PM by jsonesen
What do you think about reopening and using this ticket for the abpchrome repo as well? There is already a review: https://codereview.adblockplus.org/29907589/
Oops meant to comment on the other ticket that this one is blocking. My badddd
comment:10 Changed on 10/25/2018 at 10:45:49 AM by abpbot
A commit referencing this issue has landed:
Backed out changeset 106d231b728d (Issue 7027 - Adapted code to work with latest changes to FilterStorage.subscriptions)
comment:11 Changed on 10/25/2018 at 10:55:06 AM by greiner
- Resolution fixed deleted
- Status changed from closed to reopened
This change prematurely landed in the Mercurial master so I backed it out to allow for further fixes that need to be included in the ongoing 3.4 extension release. As soon as that one's done, we can reapply the changes.
comment:12 Changed on 11/20/2018 at 01:19:37 PM by abpbot
A commit referencing this issue has landed:
Issue 7027 - Adapted code to work with latest changes to FilterStorage.subscriptions
comment:13 Changed on 11/20/2018 at 01:20:09 PM by greiner
- Resolution set to fixed
- Status changed from reopened to closed
comment:14 Changed on 02/14/2019 at 03:24:30 PM by ukacar
- Verified working set
Added hints for testers.