Opened on 10/17/2018 at 08:42:45 AM
Closed on 08/30/2019 at 05:06:28 PM
#7055 closed change (rejected)
[Gitlab CI] [Firefox] run "publish -- gecko" though CI
| Reported by: | tlucas | Assignee: | |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Automation | Keywords: | gitlab, ci, closed-in-favor-of-gitlab |
| Cc: | sebastian, kzar, paco, matze | Blocked By: | #7020, #7053 |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/adblockpluschrome/merge_requests/36 |
||
Description (last modified by tlucas)
Background
In #7020 and #7053, we completed all necessities to publish Adblock Plus for Firefox development builds from within it's own repository, without relying on functionality from external repositories. This enables us to finally establish a full CI / CD chain for those development builds.
What to change
Add a job to adblockpluschrome's .gitlab-ci.yml, called publish:gecko, which should be run after build:gecko and only, when the job is running for the master branch.
This job should call npm run publish -- gecko ..., as implemented in #7020 / #7053.
Attachments (0)
Change History (3)
comment:1 Changed on 01/30/2019 at 02:21:47 PM by tlucas
- Priority changed from Unknown to P3
- Ready set
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 08/30/2019 at 05:06:28 PM by sebastian
- Keywords closed-in-favor-of-gitlab added
- Resolution set to rejected
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.