Opened on 10/04/2018 at 02:18:34 PM
Closed on 10/17/2018 at 06:48:24 AM
Last modified on 10/17/2018 at 08:47:49 AM
#7020 closed change (fixed)
[Gitlab CI] Sign Adblock Plus for Firefox development builds via a Node.js script
| Reported by: | tlucas | Assignee: | tlucas |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Automation | Keywords: | gitlab, ci |
| Cc: | sebastian, kzar | Blocked By: | #6682 |
| Blocking: | #7055 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by tlucas)
Background
In #6651, we introduced CI for adblockpluschrome with gitlab-ci. This enables us to implement a first approach for CD for Adblock Plus, which is also part of Priority Experiment 3.
In #6682, we started creating unsigned packages through GitLab CI/CD. Continuing with our efforts, we now want to have Adblock Plus for Firefox development builds signed and deployed through GitLab CI/CD.
What to change
Add an npm script
$ npm run publish -- gecko -p/--package <path_to_unsigned_package> -c/--credentials <path_to_oauth_credentials> -t/--target-folder <output_directory>
which let's AMO sign the unsigned package via sign-addon and copies the resulting signed package to <output_directory.
Attachments (0)
Change History (9)
comment:1 Changed on 10/04/2018 at 02:30:46 PM by tlucas
- Priority changed from P1 to P2
comment:4 Changed on 10/15/2018 at 08:59:13 AM by tlucas
- Description modified (diff)
- Owner set to tlucas
comment:5 Changed on 10/17/2018 at 06:47:52 AM by abpbot
comment:6 Changed on 10/17/2018 at 06:48:24 AM by tlucas
- Resolution set to fixed
- Status changed from new to closed
comment:8 Changed on 10/17/2018 at 08:42:45 AM by tlucas
- Blocking 7055 added
comment:9 Changed on 10/17/2018 at 08:47:49 AM by tlucas
- Summary changed from [Gitlab CI] Invoke build / deploy in GitLab CI/CD to [Gitlab CI] Sign Adblock Plus for Firefox development builds via a Node.js script
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 7020 - publish gecko with Node.js