Opened on 10/22/2018 at 05:20:11 AM

Closed on 08/29/2019 at 05:43:18 PM

#7061 closed change (rejected)

ManagedStorage additional_subscriptions

Reported by: lioncub Assignee:
Priority: Unknown Milestone:
Module: Platform Keywords: closed-in-favor-of-gitlab
Cc: philll, greiner, sebastian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Inappropriate behavior with pre configurable json.

I have a local mirror (domain.loc) of subscriptions.
I create in pre configurable json:

{
   "name": "{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}",
   "description": "Managed storage manifest for Adblock Plus",
   "type": "storage",
   "data": {
      "suppress_first_run_page": true,
      "additional_subscriptions": [
        "https://domain.loc/ruadlist+easylist.txt",
        "https://domain.loc/abp-filters-anti-cv.txt",
        "https://domain.loc/easyprivacy.txt",
        "https://domain.loc/fanboy-social.txt",
        "https://domain.loc/exceptionrules-privacy-friendly.txt"
      ]
   }
}

When you run the adblockplus automatically adds subscriptions to:

https://easylist-downloads.adblockplus.org/abp-filters-anti-cv.txt
https://easylist-downloads.adblockplus.org/ruadlist+easylist.txt
https://easylist-downloads.adblockplus.org/exceptionrules.txt

Screen: https://yadi.sk/i/E0S3ZvbETlRYnA

How to make my subscriptions from pre configurable only?
How to remove default subscriptions?

Attachments (0)

Change History (4)

comment:1 Changed on 10/22/2018 at 08:12:59 AM by mapx

  • Cc philll added

comment:2 Changed on 10/22/2018 at 08:20:46 AM by greiner

  • Cc greiner sebastian added
  • Type changed from defect to change

This behavior is intentional which is why the preference is called "additional_subscriptions". They're not meant to replace but add to the default behavior. Therefore I've changed the ticket type to reflect that.

Regarding the ticket itself, I'll leave that up to others to judge whether this is something that's worth implementing/maintaining but I assume it's not as easy as it sounds.

comment:3 Changed on 10/22/2018 at 08:21:01 AM by greiner

  • Component changed from Unknown to Platform

comment:4 Changed on 08/29/2019 at 05:43:18 PM by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from new to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
 
Note: See TracTickets for help on using tickets.