Opened on 10/23/2018 at 04:28:09 PM

Closed on 09/17/2019 at 11:57:52 AM

#7064 closed change (fixed)

[CMS] Add requirements.txt

Reported by: atudor Assignee: atudor
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: kvas Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29942562/

Description

Background

Currently, we have four 3rd party libraries that are used in CMS:

  1. requests - used in the XTM integration.
  2. urllib3 - prerequisite for requests.
  3. jinja2 - used to parse templates.
  4. werkzeug (optional) - can be used to run the test server. Offers some extra debugging information, compared to the built-in libraries.

This way, we can also avoid library-related issues, such as the one from #7057, can be easily fixed to avoid production issues.

What to change

  1. Create a file requirements.txt
  2. Add the libraries above to the file
  3. Document the use of this in README.md

Attachments (0)

Change History (4)

comment:1 Changed on 10/23/2018 at 09:15:31 PM by kvas

  • Component changed from Unknown to Sitescripts
  • Priority changed from Unknown to P3
  • Ready set

comment:2 Changed on 11/14/2018 at 04:41:44 PM by atudor

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 09/17/2019 at 11:57:15 AM by abpbot

A commit referencing this issue has landed:
Issue 7064 - Add requirements.txt

comment:4 Changed on 09/17/2019 at 11:57:52 AM by kvas

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from atudor.
 
Note: See TracTickets for help on using tickets.