Opened on 10/24/2018 at 12:53:19 PM
Closed on 10/26/2018 at 04:11:51 PM
Last modified on 10/08/2019 at 06:06:10 PM
#7066 closed defect (fixed)
Homepage meta data is ignored from some subscriptions
| Reported by: | Ross | Assignee: | greiner |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | sebastian, kzar, greiner | Blocked By: | |
| Blocking: | #6936 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/155 |
||
Description (last modified by greiner)
Environment
ABP 3.3.2.2175
Chrome 69 / Windows 10
Firefox 62 / Windows 10
Not a regression. Reproduced in 3.3.2.
How to reproduce
- Add any of the default/language filter lists.
- Add https://abptestpages.org/subscription-meta/homepage.txt as a custom subscription.
Observed behaviour
With the default/language filter list added, clicking its cog in the filter lists list displays the Website link in the menu.
With the custom filter listed added, the Website link does not appear in the menu, even if set in the filter list via the ! Homepage: xyz meta data comment.
Expected behaviour
The Website link to be displayed in the cog menu if the subscription includes the relevant meta data comment.
Further information
See ui#237.
Attachments (0)
Change History (9)
comment:2 Changed on 10/24/2018 at 05:12:56 PM by greiner
- Cc greiner added
- Component changed from Core to User-Interface
comment:3 Changed on 10/24/2018 at 05:34:48 PM by greiner
- Owner set to greiner
- Priority changed from Unknown to P2
- Ready set
I can confirm that this is merely a display issue.
As expected, the menu item is being hidden the first time it's added to the UI because we don't know its homepage value in the beginning. When we do get it from the background page, however, we don't unhide it.
Therefore the homepage menu item remains hidden when adding the filter list and it's shown after reloading the page.
comment:4 Changed on 10/24/2018 at 05:38:15 PM by greiner
- Description modified (diff)
Added link to GitLab issue.
comment:5 Changed on 10/24/2018 at 05:41:28 PM by greiner
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 10/26/2018 at 04:11:51 PM by greiner
- Blocking 6936 added
- Resolution set to fixed
- Status changed from reviewing to closed
comment:7 Changed on 04/18/2019 at 07:44:34 AM by samsun3622
spam
comment:8 Changed on 05/20/2019 at 10:58:49 AM by abpbot
A commit referencing this issue has landed:
Issue 7066 - Fixed: Website menu item remains hidden when adding a custom filter list
comment:9 Changed on 06/05/2019 at 02:23:51 PM by ukacar
- Verified working set
I can reproduce this issue. But since the homepage information is correctly reflected in the subscription object that the options page receives, I'm changing the component to User-Interface.