Opened on 11/08/2018 at 06:49:11 PM
Closed on 11/15/2018 at 11:22:07 AM
#7112 closed change (fixed)
Add centralised conftest
Reported by: | atudor | Assignee: | atudor |
---|---|---|---|
Priority: | Unknown | Milestone: | |
Module: | Sitescripts | Keywords: | |
Cc: | kvas | Blocked By: | |
Blocking: | #7090 | Platform: | Unknown / Cross platform |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description (last modified by atudor)
Background
Currently, sitescripts has one conftest.py file in the tests for sitescripts/extensions. This, however, prevents us from adding other conftest.py files when testing other modules.
What to change
In this environment, I suggest we create a dedicated conftest directory for the entire sitescripts, define specific fixtures for every module in separate files and then put them all together using the technique from here: https://gitlab.com/eyeo/websites/cms/blob/master/tests/conftest.py#L7
TO DO
- Create a /conftest directory, with a conftest.py file inside
- Move the contents of /sitescripts/extensions/test/conftest.py into a new file, /conftest/sitescripts/extensions.py
- Add the fixtures from the new file in /conftest/conftest.py, using the techique linked above.
- Add conftest at the head of the directories parsed by
Attachments (0)
Change History (3)
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 7112 - Add centralised conftest