Opened on 11/13/2018 at 12:48:10 PM
Closed on 01/22/2019 at 12:47:05 PM
Last modified on 02/07/2019 at 03:23:56 AM
#7121 closed change (fixed)
Reimplement "build.py updatepsl" as a NodeJS script
| Reported by: | tlucas | Assignee: | tlucas |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Automation | Keywords: | |
| Cc: | sebastian, mjethani | Blocked By: | |
| Blocking: | #6939, #7122 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/adblockpluschrome/merge_requests/15 |
||
Description (last modified by tlucas)
Background
We currently strive to get rid of python dependencies in adblockpluschrome and adblockpluscore.
What to change
- Reimplement the logic from $ build.py updatepsl as a NodeJS script $ npm run updatepsl for adblockpluscore
Integration notes
- Adjust the corresponding step in the Release checklist template
- Run the new script once, in adblockpluschrome, adjust the requires and mappings for publicSuffixList.js to it's new location in adblockpluscore
Attachments (0)
Change History (10)
comment:1 Changed on 11/13/2018 at 12:49:46 PM by tlucas
- Blocking 7122 added
comment:2 Changed on 11/13/2018 at 02:29:32 PM by tlucas
- Owner set to tlucas
- Priority changed from Unknown to P3
- Ready set
comment:3 Changed on 11/13/2018 at 02:30:48 PM by tlucas
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 11/15/2018 at 09:33:34 PM by mjethani
- Blocking 6939 added
comment:5 Changed on 11/16/2018 at 10:05:21 AM by tlucas
- Cc mjethani added
- Description modified (diff)
- Status changed from reviewing to reopened
comment:7 Changed on 01/21/2019 at 09:52:47 PM by abpbot
comment:8 Changed on 01/22/2019 at 12:47:05 PM by tlucas
- Resolution set to fixed
- Status changed from reopened to closed
comment:9 Changed on 01/29/2019 at 09:00:34 AM by mjethani
I think we need to update the modules page to include build/* and data/* in the Automation module.
comment:10 Changed on 02/07/2019 at 03:23:56 AM by abpbot
A commit referencing this issue has landed:
Issue 7121 - Move "updatepsl" to core
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 7121 - Move "updatepsl" to core