Opened on 11/15/2018 at 03:55:21 AM
Closed on 11/27/2018 at 06:06:21 PM
Last modified on 05/21/2019 at 10:26:03 AM
#7127 closed change (fixed)
Use npm script instead of build.py checktranslations command
| Reported by: | erikvold | Assignee: | greiner |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | tlucas, sebastian, wspee, greiner | Blocked By: | |
| Blocking: | #104 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/166 |
||
Description (last modified by greiner)
Background
We are trying to remove dependency on the buildtools repo from the adblockpluscore and adblockpluschrome repos, and replace the commands provided by buildtools with npm scripts.
https://docs.npmjs.com/misc/scripts
What to change
Add an npm script to adblockplusui to check translations, superseding build.py checktranslations.
See also ui#82.
Attachments (0)
Change History (9)
comment:1 Changed on 11/20/2018 at 02:17:21 AM by sebastian
- Cc tlucas sebastian added
- Component changed from Adblock-Plus-for-Chromium to Automation
comment:2 Changed on 11/23/2018 at 11:32:19 AM by greiner
- Cc wspee added
- Component changed from Automation to User-Interface
- Description modified (diff)
Fortunately, we're already on it (see ui#82) and are also working on extending it further to account for various other problems that may arise due to malformed translation files.
We can then also think about reusing it for Websites, in case they rely on it too. However, their requirements may differ from the UI's (e.g. we don't use them to specify the maximum length of strings) but I'm sure we could iron things out together.
comment:3 Changed on 11/23/2018 at 11:32:33 AM by greiner
- Cc greiner added
comment:4 Changed on 11/27/2018 at 12:15:43 PM by greiner
- Description modified (diff)
- Owner set to greiner
- Priority changed from Unknown to P3
- Ready set
- Summary changed from Update build.py checktranslations command to npm script to Use npm script instead of build.py checktranslations command
comment:5 Changed on 11/27/2018 at 12:24:15 PM by greiner
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 11/27/2018 at 12:32:21 PM by greiner
- Blocking 104 added
comment:7 Changed on 11/27/2018 at 06:06:21 PM by greiner
- Blocking 6936 added
- Resolution set to fixed
- Status changed from reviewing to closed
comment:8 Changed on 05/20/2019 at 10:58:28 AM by abpbot
A commit referencing this issue has landed:
Issue 7127 - Added translation file linting
comment:9 Changed on 05/21/2019 at 10:26:03 AM by kzar
- Blocking 6936 removed
Note that there are no longer any translations managed inside adblockpluschrome, but all translations have been moved to adblockplusui now (which currently depends on buildtools just for the translation related build commands). So with the migration away from (the Python-based) buildtools, all translation related commands should be rewritten as npm scripts within adblockplusui.