Opened on 11/27/2018 at 10:34:05 AM

Closed on 11/27/2018 at 11:03:34 AM

Last modified on 12/03/2018 at 12:29:28 PM

#7138 closed change (fixed)

Update adblockpluscore dependency to hg:12fe269290b3

Reported by: mjethani Assignee: kzar
Priority: P2 Milestone: Adblock-Plus-3.4.2-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: kzar, sebastian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://gitlab.com/eyeo/adblockplus/adblockpluschrome/merge_requests/19

Description (last modified by kzar)

Background

For the Adblock Plus 3.4.2 release, we would like to include the new hide-if-contains-image snippet (#7088). For this we should update the adblockpluscore dependency to hg:12fe269290b3 git:3e0f384.

What to change

Update the adblockpluscore dependency to hg:12fe269290b3 git:3e0f384. No unrelated changes will be included.

Hints for testers

Attachments (0)

Change History (8)

comment:1 Changed on 11/27/2018 at 10:35:01 AM by mjethani

  • Sensitive set

comment:2 Changed on 11/27/2018 at 10:40:15 AM by kzar

  • Cc kzar sebastian added
  • Description modified (diff)
  • Priority changed from Unknown to P2
  • Ready set
  • Sensitive unset

comment:3 Changed on 11/27/2018 at 10:40:26 AM by kzar

  • Owner set to kzar

comment:4 Changed on 11/27/2018 at 10:50:17 AM by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed on 11/27/2018 at 10:58:45 AM by abpbot

A commit referencing this issue has landed:
Issue 7138 - Update adblockpluscore dependency to 12fe269290b3

comment:6 Changed on 11/27/2018 at 11:03:07 AM by kzar

  • Milestone set to Adblock-Plus-3.4.2-for-Chrome-Opera-Firefox

comment:7 Changed on 11/27/2018 at 11:03:34 AM by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed on 12/03/2018 at 12:29:28 PM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done.

ABP 3.4.1.2204
Chrome 70 / 49 / Windows 10
Firefox 63 / 51 / Windows 10

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kzar.
 
Note: See TracTickets for help on using tickets.