Opened on 11/27/2018 at 05:15:04 PM
Closed on 03/12/2019 at 12:51:19 PM
Last modified on 07/10/2019 at 12:15:43 PM
#7140 closed defect (fixed)
CI Pipeline succeeds despite linting errors
| Reported by: | agiammarchi | Assignee: | agiammarchi |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #6936 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/169 |
||
Description
As described in https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/253, our linting does not exit when errors happen so that we need to update one module to work properly.
Attachments (0)
Change History (7)
comment:1 Changed on 03/12/2019 at 12:33:19 PM by greiner
- Blocking 6936 added
comment:2 Changed on 03/12/2019 at 12:51:04 PM by greiner
- Owner set to agiammarchi
- Priority changed from Unknown to P3
- Ready set
comment:3 Changed on 03/12/2019 at 12:51:19 PM by greiner
- Resolution set to fixed
- Status changed from new to closed
comment:4 Changed on 05/20/2019 at 10:58:51 AM by abpbot
A commit referencing this issue has landed:
Issue 7140 - use latest npm-dollar module
comment:5 Changed on 05/21/2019 at 10:26:03 AM by kzar
- Blocking 6936 removed
comment:6 Changed on 05/21/2019 at 11:18:21 AM by kzar
- Blocking 6936 added
comment:7 Changed on 07/10/2019 at 12:15:43 PM by ukacar
- Verified working set
Note: See
TracTickets for help on using
tickets.
Done: https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/commit/6b69bede9b840af4d338480ac64d9fae51f52ee5