Opened on 11/29/2018 at 04:46:02 PM
Closed on 11/30/2018 at 12:51:36 PM
#7149 closed change (duplicate)
Adjust adblockpluschrome to handle FilterStorage.subscriptions changes
| Reported by: | jsonesen | Assignee: | jsonesen |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Platform | Keywords: | |
| Cc: | mjethani, hfiguiere, kzar, snoack | Blocked By: | |
| Blocking: | #7054 | Platform: | Unknown / Cross platform |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
Issue #6856 introduced changes to the FilterStorage, adblockpluschrome/lib/subscriptionsInit.js must be adapted.
What to change
Where FilterStorage.subscriptions is iterated over use the generator call FilterStorage.subscriptions() where subscriptions.length is called use FilterStorage.subscriptionCount
Hints for testers
Ensure that accessing, and adding new lists, as well as adding user created filters is not broken
Attachments (0)
Change History (6)
comment:1 Changed on 11/29/2018 at 04:47:51 PM by jsonesen
- Milestone set to Adblock-Plus-3.4.2-for-Chrome-Opera-Firefox
- Review URL(s) modified (diff)
comment:2 Changed on 11/29/2018 at 04:48:54 PM by jsonesen
- Blocking 7054 added
- Cc mjethani hfiguiere kzar snoack added
comment:3 Changed on 11/29/2018 at 04:56:25 PM by jsonesen
- Summary changed from Adjust adblockplus to handle FilterStorage.subscriptions changes to Adjust adblockpluschrome to handle FilterStorage.subscriptions changes
comment:4 Changed on 11/29/2018 at 04:57:05 PM by jsonesen
- Owner changed from Sonesen to jsonesen
comment:5 Changed on 11/29/2018 at 10:17:04 PM by mjethani
comment:6 Changed on 11/30/2018 at 12:51:36 PM by kzar
- Component changed from Core to Platform
- Milestone Adblock-Plus-3.4.2-for-Chrome-Opera-Firefox deleted
- Resolution set to duplicate
- Status changed from new to closed
Closing this, since as Manish mentions these changes should be made as a part of #7054. He's also right that this would be a Platform (adblockpluschrome) change.
The milestone should generally be assigned when the issue is fixed, not when you first created it. Also, this is not planned to be included in the upcoming 3.4.2 release anyway.
Please let me know if I goofed the ticket anywhere, thanks!