Opened on 06/24/2014 at 03:09:52 PM
Closed on 01/08/2015 at 04:21:19 PM
Last modified on 02/19/2015 at 07:37:36 AM
#715 closed change (fixed)
Return an UTF-8 string for the PROC_GET_DOCUMENTATION_LINK message
| Reported by: | fhd | Assignee: | Mailkov |
|---|---|---|---|
| Priority: | P4 | Milestone: | Adblock-Plus-for-Internet-Explorer-1.4 |
| Module: | Adblock-Plus-for-Internet-Explorer | Keywords: | goodfirstbug |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Internet Explorer | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Background
libadblockplus works with UTF-8 strings, while IE works with UTF-16 strings. Because of this, we need to convert back and forth.
We do most of these conversions in the tab processes, but for the PROC_GET_DOCUMENTATION_LINK message, we're actually expecting an UTF-16 string from the engine process.
What to change
Return an UTF-8 string for the PROC_GET_DOCUMENTATION_LINK message in the engine process (Main.cpp). Convert it to an UTF-16 string in the tab processes (AdblockPlusClient.cpp).
Attachments (0)
Change History (6)
comment:1 Changed on 01/02/2015 at 01:23:08 PM by Mailkov
comment:2 Changed on 01/02/2015 at 01:37:12 PM by fhd
- Owner set to Mailkov
- Platform set to Internet Explorer
Sure!
comment:3 Changed on 01/07/2015 at 07:35:41 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 01/07/2015 at 07:39:22 PM by Mailkov
Done !!!
Pull request : https://github.com/adblockplus/adblockplusie/pull/3
comment:5 Changed on 01/08/2015 at 04:21:19 PM by oleksandr
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 Changed on 02/19/2015 at 07:37:36 AM by oleksandr
- Milestone set to Adblock-Plus-for-Internet-Explorer-1.4
Note: See
TracTickets for help on using
tickets.
Hi , I would like to work on this bug