Opened on 11/30/2018 at 02:55:26 PM

Closed on 12/03/2018 at 04:22:58 PM

Last modified on 02/14/2019 at 03:24:38 PM

#7151 closed change (fixed)

Adapt code to work with renamed FilterStorage

Reported by: greiner Assignee: greiner
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: wspee Blocked By:
Blocking: #7054 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

​https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/181

Description (last modified by greiner)

Background

See ​ui#261

What to change

See ​ui#261

Hints for testers

  • Filter lists in desktop and mobile options page should be shown.
  • Custom filters in desktop options page should be shown and adding/removing custom filters should work as expected.

Attachments (0)

Change History (6)

comment:1 Changed on 11/30/2018 at 02:57:23 PM by greiner

  • Blocking 7054 added

comment:2 Changed on 11/30/2018 at 04:55:27 PM by greiner

  • Description modified (diff)

Added hints for testers.

comment:3 Changed on 11/30/2018 at 05:38:14 PM by greiner

  • Description modified (diff)
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 12/03/2018 at 04:22:58 PM by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

Done: ​https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/commit/8d50db6f16f57ba95b34d0ca16a008c1035f07af

comment:5 Changed on 12/04/2018 at 02:36:04 PM by abpbot

A commit referencing this issue has landed:
​Issue 7151 - Renamed FilterStorage to filterStorage

comment:6 Changed on 02/14/2019 at 03:24:38 PM by ukacar

  • Verified working set

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from greiner.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.