Opened on 12/11/2018 at 01:25:23 PM
Closed on 02/21/2019 at 02:00:45 PM
Last modified on 04/01/2019 at 09:52:04 AM
#7164 closed change (fixed)
Create test page for sitekey filters
| Reported by: | Ross | Assignee: | |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Websites | Keywords: | |
| Cc: | kzar | Blocked By: | #7282, #7290 |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/testpages.adblockplus.org/merge_requests/6 |
||
Description
Background
There are no test pages for testing the sitekey filter option. (There used to be one in the old test pages).
What to change
Create a test page that allows the user to test if sitekey filters are working as expected. The page should consist of:
- An "ad" element on the page.
- A frame on the page, containing an "ad" element.
- A filter that hides the two above elements.
- The sitekey filter required to unhide the two above elements.
The key part of this issue should already be set up as described in #3339.
Attachments (0)
Change History (8)
comment:1 Changed on 02/15/2019 at 10:07:39 AM by Ross
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 02/15/2019 at 10:48:00 AM by Ross
- Ready set
comment:3 Changed on 02/15/2019 at 11:43:57 AM by kzar
- Blocked By 7282 added
comment:4 Changed on 02/15/2019 at 11:57:33 AM by abpbot
comment:5 Changed on 02/15/2019 at 01:07:26 PM by kzar
So far this isn't working, but looking into it the extension is failing to verify the given signature. It looks like this is a problem with the sitekey-frame code in sitescripts.
comment:6 Changed on 02/15/2019 at 01:15:00 PM by kzar
- Blocked By 7290 added
comment:7 Changed on 02/21/2019 at 02:00:45 PM by kzar
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 7164 - Create test page for sitekey filters