Automated tests no longer just run on Windows

[Ross]

Environment

adblockpluschrome / master / 2207:96eda29ae585

How to reproduce

1. Clone/update repository.
2. Run ./ensure_dependencies.py (from WSL command prompt)

Method 1:

3. Run npm install from a Windows command prompt.
4. Run npm test from a Windows command prompt.

Method 2:

3. Run npm install from a Windows command prompt.
4. Run npm test from a WSL command prompt.

Method 3:

3. Run npm install from a WSL command prompt.
4. Run npm test from a WSL command prompt.

Observed behaviour

Method 1:
Install the Windows version of webdriver but both Chrome and Gecko driver are not in the PATH env:

Error: The ChromeDriver could not be found on the current PATH

Error: The geckodriver.exe executable could not be found on the current PATH.

Method 2:
Both Chrome and Gecko tests fail at the start with:

Uncaught Error: Server terminated early with status 2
at earlyTermination.catch.e (node_modules/selenium-webdriver/remote/index.js:252:52)

Method 3:
Running npm install from the WSL prompt causes the Linux version of the webdriver binaries to be installed, which obviously don't run:

Uncaught Error: Server terminated early with status 127

Expected behaviour

The automated tests to run successfully. Method 1 and 2 were what I was using previously to run automated tests. Method 1 works if I manually add the webdriver paths in node_modules to my PATH env. However I didn't need to do that before and am unsure what has changed.

[kzar]

Ross if you have time, please could you bisect this for us? It would be interesting to know which commit introduced the regression. In other words, please could you find the last commit where the tests run OK on Windows?

[Ross]

Of course. I'll see if I can do that this afternoon.

[sebastian]

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the ​new issue tracker.