Opened on 12/17/2018 at 11:02:49 AM
Closed on 01/10/2019 at 08:37:40 PM
Last modified on 01/17/2019 at 04:02:43 AM
#7173 closed defect (fixed)
Popup UI issues when viewing local files in Edge
| Reported by: | Ross | Assignee: | geo |
|---|---|---|---|
| Priority: | Unknown | Milestone: | Adblock-Plus-3.4.3-for-Chrome-Opera-Firefox |
| Module: | User-Interface | Keywords: | |
| Cc: | sebastian, kzar, greiner, geo | Blocked By: | |
| Blocking: | Platform: | Edge | |
| Ready: | no | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/191 |
||
Description (last modified by kzar)
Environment
ABP 0.9.11.2206
Edge 42.17134.1.0 / EdgeHTML 17.17134
How to reproduce
- Download a PDF, e.g. https://www.justice.gov/file/1007271/download
- Open that downloaded file in Edge, so the URL should be something like file:///C:/Users/username/Desktop/untitled.pdf
- Open Popup UI.
Observed behaviour
The Popup UI looks broken:
- The top right corner of the Popup UI the Options Cog has the word "Options" over the top of it.
- The "Number of items blocked" section is also displayed, but is blank.
Expected behaviour
The Options Cog link in the Popup UI to look as it does on a normal webpage. I'm unsure if the "Number of items blocked" section should be hidden here.
Attachments (1)
Change History (11)
Changed on 12/17/2018 at 11:04:03 AM by Ross
comment:1 Changed on 01/09/2019 at 11:11:00 PM by geo
comment:2 Changed on 01/09/2019 at 11:13:20 PM by geo
- Owner set to geo
- Review URL(s) modified (diff)
comment:3 Changed on 01/10/2019 at 01:37:39 PM by kzar
- Description modified (diff)
- Summary changed from Popup UI issues when viewing files in Edge to Popup UI issues when viewing local files in Edge
comment:4 Changed on 01/10/2019 at 08:33:28 PM by abpbot
A commit referencing this issue has landed:
Issue 7173 - Fixed popup UI issues when viewing files in MS Edge
comment:5 Changed on 01/10/2019 at 08:36:49 PM by abpbot
A commit referencing this issue has landed:
Issue 7173 - Updated adblockplusui dependency, fixing popup issues on MS Edge
comment:6 Changed on 01/10/2019 at 08:37:40 PM by sebastian
- Resolution set to fixed
- Status changed from new to closed
comment:7 Changed on 01/14/2019 at 11:11:07 AM by greiner
Mind adding a link to the respective GitLab issue to the ticket description?
comment:8 Changed on 01/14/2019 at 04:27:23 PM by kzar
- Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
comment:9 Changed on 01/15/2019 at 01:42:18 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Fixed.
ABP 0.9.11.2216 (Devbuild)
Edge 44.17763.1.0 / EdgeHTML 18.17763
comment:10 Changed on 01/17/2019 at 04:02:43 AM by sebastian
- Milestone changed from Adblock-Plus-for-Chrome-Opera-Firefox-next to Adblock-Plus-3.4.3-for-Chrome-Opera-Firefox
The cause of the bug is that for local files browser.tabs.query returns an array of tabs with url undefined. Execution context doesn't matter.