Opened on 01/04/2019 at 11:29:12 AM

Closed on 01/07/2019 at 12:10:47 PM

Last modified on 02/21/2019 at 08:56:00 AM

#7191 closed change (fixed)

Remove unused qunit/common.js file

Reported by: kzar Assignee: kzar
Priority: P2 Milestone: Adblock-Plus-3.5-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: sebastian, jsonesen Blocked By: #7192
Blocking: #7054 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

​https://gitlab.com/eyeo/adblockplus/adblockpluschrome/merge_requests/23

Description (last modified by kzar)

Background

The adblockpluschrome unit tests include a file qunit/common.js, which contains some common functions. Those functions are no longer being used anywhere, it seems they were somehow leftover from the legacy Firefox extension and its tests.

What to change

  • Remove the qunit/common.js file.
  • Update the buildtools dependency to hg:33f115e8c1b3 git:f02a6f2 to include the required packager changes (see #7192).

Notes

  • I have verified that the builds (chrome, gecko & edge) are not otherwise effected by this buildtools dependency update.

Attachments (0)

Change History (12)

comment:1 Changed on 01/04/2019 at 11:29:34 AM by kzar

  • Description modified (diff)

comment:2 Changed on 01/04/2019 at 11:29:44 AM by kzar

  • Ready set

comment:3 Changed on 01/04/2019 at 11:32:49 AM by kzar

  • Blocked By 7192 added

comment:4 Changed on 01/04/2019 at 11:54:42 AM by kzar

  • Blocked By 7192 removed
  • Description modified (diff)

comment:5 Changed on 01/04/2019 at 11:58:51 AM by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed on 01/04/2019 at 03:29:57 PM by kzar

  • Blocked By 7192 added

comment:7 Changed on 01/07/2019 at 10:29:39 AM by kzar

  • Description modified (diff)

comment:8 Changed on 01/07/2019 at 12:02:53 PM by abpbot

A commit referencing this issue has landed:
​Issue 7191 - Remove unused qunit/common.js file

comment:9 follow-up: Changed on 01/07/2019 at 12:10:47 PM by kzar

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:10 in reply to: ↑ 9 Changed on 02/19/2019 at 12:03:34 PM by ukacar

Replying to kzar:
Is there anything to test here?

comment:11 Changed on 02/20/2019 at 08:44:03 AM by kzar

No, nothing to test here. Sorry, I should have mentioned that in the description.

comment:12 Changed on 02/21/2019 at 08:56:00 AM by ukacar

  • Verified working set

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kzar.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.