Opened on 01/14/2019 at 02:32:14 PM
Closed on 01/14/2019 at 03:56:15 PM
Last modified on 01/17/2019 at 04:02:43 AM
#7212 closed change (fixed)
Ensure migration path from builds for Microsoft Edge to builds for Chromium
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-3.4.3-for-Chrome-Opera-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | geo, kzar | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/adblockpluschrome/merge_requests/28 |
||
Description (last modified by sebastian)
Background
With Microsoft Edge replacing EdgeHTML with Chromium, and consequently the existing extension infrastructure with Chrome extensions, we should make sure that when migrating from the current Adblock Plus for Microsoft Edge to a build for Chromium-based browsers, all data are preserved (assuming that Microsoft Edge will persist the data in storage.local through the update process).
Currently, in the builds for the old Microsoft Edge, we store filter data in IndexedDB (which our builds for Chromium-based browsers are agnostic of). However, starting with #6775 we backup the filter data into storage.local, though using a bogus key (i.e. file:indexedDB-backup), while Adblock Plus for Chrome is only looking for filter data stored with the key file:patterns.ini. If we rename that key accordingly the backup should be picked up after the migration without requiring further changes.
What to change
Store backups written to storage.local on (the old) Microsoft Edge with the key file:patterns.ini.
Hints for testers
Before a preview build of the Chromium-based version of Microsoft Edge becomes available there is no ultimate way to make sure that this will be working as expected. However, you might want to make sure that this change doesn't break #6775. Also see the note in the review, for some improvised test instructions.
Attachments (0)
Change History (8)
comment:1 Changed on 01/14/2019 at 02:48:59 PM by sebastian
comment:2 Changed on 01/14/2019 at 03:54:57 PM by abpbot
comment:3 Changed on 01/14/2019 at 03:56:15 PM by sebastian
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 01/14/2019 at 04:26:37 PM by kzar
- Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
comment:5 Changed on 01/15/2019 at 02:12:34 PM by Ross
Should I be able to check this like below in the background console?
browser.storage.local.get("file:patterns.ini").then(console.log);
comment:6 Changed on 01/15/2019 at 06:41:55 PM by sebastian
- Description modified (diff)
I added some hints for testers to the issue description.
comment:8 Changed on 01/17/2019 at 04:02:43 AM by sebastian
- Milestone changed from Adblock-Plus-for-Chrome-Opera-Firefox-next to Adblock-Plus-3.4.3-for-Chrome-Opera-Firefox
A commit referencing this issue has landed:
Issue 7212 - Write backups on MS Edge to "file:patterns.ini", to be picked up on Chromium