Opened on 01/15/2019 at 02:39:46 PM
Closed on 01/15/2019 at 04:50:30 PM
Last modified on 01/17/2019 at 04:02:43 AM
#7216 closed defect (fixed)
Options page can be opened multiple times
| Reported by: | kzar | Assignee: | kzar |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-3.4.3-for-Chrome-Opera-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | Ross, sebastian, geo | Blocked By: | |
| Blocking: | Platform: | Edge | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/adblockpluschrome/merge_requests/30 |
||
Description (last modified by kzar)
Environment
Edge 44.17763.1.0, Adblock Plus 0.9.11
How to reproduce
- Click the Adblock Plus logo.
- Click the Cog symbol to open the options page.
- Repeat
Observed behaviour
The options page opens each time the cog button is clicked, even if it was already open.
Expected behaviour
If the options page is already open, clicking the cog should instead switch to that tab.
Notes
- Thanks to Ross for spotting this one.
- It seems that Microsoft have added the browser.runtime.openOptionsPage somewhere in between version 42 and 44 of Edge, but it doesn't function properly. It opens the options page each time it's called, even if the options page is already open.
- See this Microsoft Edge bug: https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/20196382/
- This in turn causes more problems, see #7215.
Attachments (0)
Change History (6)
comment:1 Changed on 01/15/2019 at 02:45:27 PM by kzar
comment:3 Changed on 01/15/2019 at 04:50:02 PM by abpbot
comment:4 Changed on 01/15/2019 at 04:50:30 PM by kzar
- Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 01/16/2019 at 01:01:31 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Fixed.
ABP 0.9.11.2223 (Devbuild)
Edge 44.17763.1.0 / EdgeHTML 18.17763
comment:6 Changed on 01/17/2019 at 04:02:43 AM by sebastian
- Milestone changed from Adblock-Plus-for-Chrome-Opera-Firefox-next to Adblock-Plus-3.4.3-for-Chrome-Opera-Firefox
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 7216 - Avoid using broken openOptionsPage API on Edge