Opened on 01/18/2019 at 04:38:56 PM

Closed on 01/18/2019 at 05:11:54 PM

Last modified on 01/25/2019 at 02:01:15 PM

#7226 closed change (fixed)

Update adblockpluscore dependency to hg:eadcd5fff827

Reported by: hfiguiere Assignee: hfiguiere
Priority: P2 Milestone: Adblock-Plus-3.4.3-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: kzar, sebastian, mjethani Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29985555/

Description

Background

For the upcoming snippet release of Adblock Plus for Chrome, Firefox and Opera (3.4.3), we would like to update the dependency to the current master branch of adblockpluscore.

This includes the following change:

  • #7158 - Update subscriptions.xml to include Malay coverage with Indonesian

What to change

Update the adblockpluscore dependency to hg:eadcd5fff827 git:3d62dbb.

Hints for testers

Please see the hints mentioned in the tickets linked above.

Attachments (0)

Change History (6)

comment:1 Changed on 01/18/2019 at 04:52:17 PM by kzar

  • Priority changed from Unknown to P2
  • Ready set

comment:2 Changed on 01/18/2019 at 04:52:32 PM by kzar

  • Milestone set to Adblock-Plus-3.4.3-for-Chrome-Opera-Firefox

comment:3 Changed on 01/18/2019 at 05:08:50 PM by abpbot

A commit referencing this issue has landed:
Issue 7226 - Update adblockpluscore dependency to hg:eadcd5fff827

comment:4 Changed on 01/18/2019 at 05:11:54 PM by hfiguiere

  • Resolution set to fixed
  • Review URL(s) modified (diff)
  • Status changed from new to closed

comment:5 Changed on 01/23/2019 at 12:33:15 AM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done.

ABP 3.4.2.2231
Chrome 71.0.3578.98 / Windows 10 (Latest)
Chrome 49.0.2623.75 / Windows 10 (Min supported)
Firefox 64.0.2 / Windows 10 (Latest)
Firefox 51.0 / Windows 10 (Min supported)
Opera 57.0.3098.76 / Windows 10 (Latest)
Opera 36.0.2130.65 / Windows 10 (Min supported)

comment:6 Changed on 01/25/2019 at 02:01:15 PM by Ross

Also fine in Edge.

ABP 0.9.12.2237
Edge 44.17763.1.0 / EdgeHTML 18.17763 / Windows 10

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from hfiguiere.
 
Note: See TracTickets for help on using tickets.