Opened on 01/25/2019 at 06:09:12 PM

Closed on 08/28/2019 at 11:56:17 AM

#7240 closed change (rejected)

Provide script to rebuild resources.json

Reported by: hfiguiere Assignee: hfiguiere
Priority: Unknown Milestone:
Module: Automation Keywords:
Cc: sebastian, mjethani Blocked By: #7067
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29933567/
​https://gitlab.com/eyeo/adblockplus/adblockpluscore/merge_requests/101

Description

Background

Issue #7067 introduced resources.json.

Provide the necessary files to rebuild the resources.json, including adding more to it.

What to change

  • Add the make_resources.js script file
  • Add an entry in the package.json
  • Add the necessary sources (binaries and index)

Attachments (0)

Change History (5)

comment:1 Changed on 01/28/2019 at 05:22:59 PM by hfiguiere

  • Owner set to hfiguiere

comment:2 Changed on 01/28/2019 at 05:23:06 PM by hfiguiere

  • Status changed from new to reviewing

comment:3 Changed on 07/10/2019 at 04:21:16 AM by hfiguiere

  • Review URL(s) modified (diff)

comment:4 Changed on 08/27/2019 at 06:40:57 PM by mjethani

Any reason why this is marked confidential?

comment:5 Changed on 08/28/2019 at 11:56:17 AM by sebastian

  • Cc sebastian mjethani added
  • Component changed from Core to Automation
  • Resolution set to rejected
  • Sensitive unset
  • Status changed from reviewing to closed

Rejecting this issue for ​reasons outlined in the merge request.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from hfiguiere.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.