Opened on 01/30/2019 at 10:51:43 AM
Closed on 03/12/2019 at 12:56:21 PM
Last modified on 07/10/2019 at 12:10:43 PM
#7247 closed change (fixed)
Improve filter table search visualization
| Reported by: | agiammarchi | Assignee: | agiammarchi |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #6936 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/210 |
||
Description (last modified by agiammarchi)
As mentioned in https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/294, it is actually not fully clear by either specs or implementation how matching searches should be somehow highlighted in the list of custom filters.
As discussed in this comment https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/294#note_136451655 we would like to give the users a powerful way to visualize their searches:
- automatically select any matching custom filter in the list
- give the ability to delete or copy all matches
- scroll into the closest match from the top or
- scroll into the exact match, if any
The search will perform only if there are at least 3 chars in the text field, otherwise nothing would happen.
Attachments (0)
Change History (7)
comment:3 Changed on 03/12/2019 at 12:38:09 PM by greiner
- Blocking 6936 added
comment:4 Changed on 03/12/2019 at 12:56:01 PM by greiner
- Owner set to agiammarchi
- Priority changed from Unknown to P3
comment:5 Changed on 03/12/2019 at 12:56:21 PM by greiner
- Resolution set to fixed
- Status changed from new to closed
comment:6 Changed on 05/20/2019 at 10:58:17 AM by abpbot
A commit referencing this issue has landed:
Issue 7247 - Improve filter table search visualization
comment:7 Changed on 07/10/2019 at 12:10:43 PM by ukacar
- Verified working set
Done: https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/commit/6d42c8451affc0fb2c0dc089e70e6365a7652a73