Opened on 02/05/2019 at 06:22:54 AM
Closed on 08/29/2019 at 05:43:52 PM
#7261 closed change (rejected)
Remove use of jquery and qunit in buildtools and adblockpluschrome
| Reported by: | erikvold | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Core | Keywords: | closed-in-favor-of-gitlab |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
jquery is dead we shouldn't use it and there is no need to use it anymore. Since quint uses it, it also should be replaced (in issue #6820 we plan to move away from nodeunit anyhow, if we use mocha-style tests, or others, then we can run those tests in node and in the browser).
Also, there will be a new manifest version coming (v3), we will be forced to support only new versions of chrome, and not older versions so we shouldn't have a need for jquery on that front.
So since we have the new manifest coming, and we plan to move away from nodeunit to something else (which will prob support in browser testing as mocha-style tests would), and because we are planning to migrate from hg to git (which is good opportunity to remove the dependency on buildtools, which contains jquery and qunit), I think now would be a good time to remove the jquery and qunit code.
Attachments (0)
Change History (2)
comment:1 Changed on 02/05/2019 at 06:51:13 AM by erikvold
- Summary changed from Remove use of jquery and qunit in buildtools to Remove use of jquery and qunit in buildtools and adblockpluschrome
comment:2 Changed on 08/29/2019 at 05:43:52 PM by sebastian
- Keywords closed-in-favor-of-gitlab added
- Resolution set to rejected
- Status changed from new to closed
Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.