Opened on 02/12/2019 at 12:53:53 PM
Closed on 02/22/2019 at 12:47:46 PM
Last modified on 02/25/2019 at 01:28:40 PM
#7277 closed defect (fixed)
The number of blocked items is not displayed
| Reported by: | geo | Assignee: | geo |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-3.5-for-Chrome-Opera-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | kzar, Ross, sebastian, ukacar, rscott | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/adblockpluschrome/merge_requests/41/ |
||
Description (last modified by kzar)
Environment
Adblock Plus development build 3.4.3.2253
Older versions of Chrome (<= 66) and Opera (<= 54)
AND
Adblock Plus development build 0.9.13.2252
Microsoft Edge 44.17763.1.0 & 42.17134.1.0
How to reproduce
- Navigate to https://www.nytimes.com/
Observed behaviour
- Observe that the ABP icon in the browser's toolbar does not display the number of the blocked ads.
- Open the background page and observe errors in the console:
Uncaught Error: Invocation of form browserAction.setBadgeText(object, function) doesn't match definition browserAction.setBadgeText(object details)
Expected behaviour
There should be no errors in the console of the background page, ABP icon should display the number of blocked items
Notes
- This is a regression compared to the previous Edge release (0.9.13) and the previous Chrome/Opera release (3.4.3).
- This ticket is a follow up from this discussion
- We suspect the regression was caused by this commit: Issue 6940 - Wrap browser.browserAction.set* with promise.
Hints for testers
- Test that the number of blocked items is now displayed on Edge and older versions of Chrome and Opera. Also, that it is continued to be displayed on Firefox and a recent version of Chrome.
- Test that our devtools panel is still created and working properly in Chrome.
Attachments (0)
Change History (8)
comment:1 Changed on 02/12/2019 at 12:57:43 PM by geo
- Cc Ross sebastian added
comment:2 Changed on 02/15/2019 at 01:41:16 PM by kzar
- Milestone set to Adblock-Plus-3.5-for-Chrome-Opera-Firefox
- Owner set to geo
- Priority changed from Unknown to P1
- Ready set
comment:4 Changed on 02/18/2019 at 10:03:47 AM by kzar
- Description modified (diff)
- Platform changed from Edge to Unknown / Cross platform
comment:6 Changed on 02/22/2019 at 12:44:10 PM by abpbot
Some commits referencing this issue have landed:
comment:7 Changed on 02/22/2019 at 12:47:46 PM by kzar
- Cc ukacar rscott added
- Resolution set to fixed
- Status changed from new to closed
Heads up, the patch just landed so it should start showing up in the development build soon.
comment:8 Changed on 02/25/2019 at 01:28:40 PM by ukacar
- Verified working set
Note: See
TracTickets for help on using
tickets.
Ursa has found the same problem in older versions of Chrome and Opera, I've updated this issue and marked #7297 as a duplicate of this.