Exception in element hiding emulation

[hfiguiere]

Environment

Chrome or Firefox

How to reproduce

1. Disable all filters.
2. Add the following filter wp.pl#?#div:-abp-properties(box-sizing: content-box;):-abp-has(a > div)
3. Visit ​https://finanse.wp.pl/tasmy-kaczynskiego-mec-jacek-dubois-kaczynski-musi-zostac-przesluchany-6349714442750081v

Observed behaviour

In the web console there is an exception:

elemHideEmulation.js:189 Uncaught DOMException: Failed to execute 'querySelectorAll' on 'Document': '._3bcRuc4 div*' is not a valid selector.
    at scopedQuerySelector (chrome-extension://ldcecbkkoecffmfljeihcmifjjdoepkn/include.preload.js:789:24)
    at scopedQuerySelectorAll (chrome-extension://ldcecbkkoecffmfljeihcmifjjdoepkn/include.preload.js:795:10)
    at HasSelector.getElements (chrome-extension://ldcecbkkoecffmfljeihcmifjjdoepkn/include.preload.js:913:20)
    at getElements.next (<anonymous>)
    at HasSelector.getSelectors (chrome-extension://ldcecbkkoecffmfljeihcmifjjdoepkn/include.preload.js:898:14)
    at getSelectors.next (<anonymous>)
    at evaluate (chrome-extension://ldcecbkkoecffmfljeihcmifjjdoepkn/include.preload.js:828:30)
    at evaluate.next (<anonymous>)
    at evaluate (chrome-extension://ldcecbkkoecffmfljeihcmifjjdoepkn/include.preload.js:834:14)
    at evaluate.next (<anonymous>)

Expected behaviour

No exception

Hint to testers

You can test this on one or our testpages.

1. Add the filter adblockplus.org#?#div:-abp-properties(float: left;)
2. Visit ​https://testpages.adblockplus.org/en/filters/element-hiding-emulation
3. If the bug is here, there is an exception in the console:

   include.preload.js:1407 Uncaught DOMException: Failed to execute 'querySelectorAll' on 'Document': '#site-header-logo > div*' is not a valid selector.
       at processPatterns (chrome-extension://fagebjibnhbcaljjbhoialonelckpden/include.preload.js:1407:45)
       at processPatterns (chrome-extension://fagebjibnhbcaljjbhoialonelckpden/include.preload.js:1420:14)
       at ElemHideEmulation._addSelectors (chrome-extension://fagebjibnhbcaljjbhoialonelckpden/include.preload.js:1423:5)
       at HTMLDocument.handler (chrome-extension://fagebjibnhbcaljjbhoialonelckpden/include.preload.js:1509:14)
   

4. If fixes, the logo should disappear at the top.

[mjethani]

This ticket is OK except there needs to be a standalone test case so the bug/fix can be verified even if the original document has changed.

@hfiguiere can you make this reproducible without referring to external content not under our control?

In the Expected behavior section, we need to also clarify which elements should be hidden.

[abpbot]

A commit referencing this issue has landed:
​Issue 7291 - Don't mangle selectors with a '*'

[abpbot]

A commit referencing this issue has landed:
​Issue 7291 - Handle *.foo in qualifySelector()

[hfiguiere]

Added a fixed testcase in the "Hints for tester" section.

Ideally we would craft a test case. It requires to have in the stylesheet a rules that ends with a '*'.

[Ross]

Fixed. Working as described.

ABP 0.9.15.2340
Microsoft Edge 44.17763.1.0 / Windows 10 1809

ABP 3.5.2.2340
Chrome 49.0.2623.75 / Windows 10 1809
Chrome 75.0.3770.142 / Windows 10 1809
Opera 36.0.2130.65 / Windows 10 1809
Opera 62.0.3331.72 / Windows 10 1809
Firefox 51.0 / Windows 10 1809
Firefox 68.0 / Windows 10 1809
Firefox Mobile 68.0 / Android 7.2.2