Opened on 02/15/2019 at 05:29:56 PM
Closed on 03/05/2019 at 05:07:57 PM
Last modified on 08/26/2019 at 02:27:02 PM
#7293 closed change (fixed)
Remove "+" prefix from translatable strings
| Reported by: | greiner | Assignee: | greiner |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/225 |
||
Description (last modified by greiner)
Background
See ui#334
What to change
See ui#334
Hints for testers
The following buttons should have a text that's preceded by a "+" character and separated by a space:
Mobile options page
- "Add a language" button in General tab
- "Add a new filter list" button in Advanced tab
Desktop options page
- "Add a filter list" button
- "Add a custom filter list" button in dialog that appears when clicking on "Add a filter list" button
The position of the "+" and space should be inverted for RTL locales.
Hints for translators
Remove + prefix from the following strings:
- mops_filterlist_add
- mops_filterlist_add_url
- options_filterList_add
- options_language_add
Attachments (0)
Change History (5)
comment:2 Changed on 02/15/2019 at 05:58:00 PM by greiner
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 03/05/2019 at 05:07:57 PM by greiner
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 08/26/2019 at 02:27:02 PM by abpbot
A commit referencing this issue has landed:
Issue 7293 - Moved decorative prefix out of translatable strings
Note: See
TracTickets for help on using
tickets.
Added hints for testers section.