Opened on 02/20/2019 at 06:39:14 PM
Closed on 08/30/2019 at 04:30:22 PM
#7307 closed change (rejected)
Add rules to disallow trailing whitespaces to stylelint-config-eyeo
| Reported by: | greiner | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Automation | Keywords: | closed-in-favor-of-gitlab |
| Cc: | ire, juliandoucette, agiammarchi, saroyanm | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
According to our coding style, trailing whitespaces are not allowed. While we do enforce that in eslint-config-eyeo, we don't yet in stylelint-config-eyeo. Therefore we should add the necessary rules to it.
What to change
Add the following rules to stylelint-config-eyeo:
- "no-eol-whitespace": true
- "no-missing-end-of-source-newline": true
Further information
The above rules are unable to detect trailing whitespaces in empty lines.
Attachments (0)
Change History (1)
comment:1 Changed on 08/30/2019 at 04:30:22 PM by sebastian
- Keywords closed-in-favor-of-gitlab added
- Resolution set to rejected
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.