Opened on 02/26/2019 at 07:33:25 AM
Closed on 03/01/2019 at 06:32:34 AM
Last modified on 07/25/2019 at 02:23:18 PM
#7311 closed change (fixed)
Fix performance regression introduced in changeset 0da36169b1a4 (#7267)
| Reported by: | mjethani | Assignee: | mjethani |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Core | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by mjethani)
Background
After changset 0da36169b1a4 the _checkEntryMatch() function takes longer. It is not clear why this is, but it is possibly because of the additional lines of code that cause the function to be deoptimized on V8.
What to change
Split _checkEntryMatchByDomain() into two smaller functions for the Filter and Map cases.
Hints for testers
Same as #7265.
Attachments (0)
Change History (6)
comment:1 Changed on 02/26/2019 at 12:39:17 PM by mjethani
- Blocking 7000 removed
comment:2 Changed on 02/27/2019 at 11:44:27 AM by abpbot
comment:5 Changed on 03/01/2019 at 06:32:34 AM by mjethani
- Resolution set to fixed
- Review URL(s) modified (diff)
- Status changed from new to closed
comment:6 Changed on 07/25/2019 at 02:23:18 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Working as described in #7265.
ABP 0.9.15.2340
Microsoft Edge 44.17763.1.0 / Windows 10 1809
ABP 3.5.2.2340
Chrome 49.0.2623.75 / Windows 10 1809
Chrome 75.0.3770.142 / Windows 10 1809
Opera 36.0.2130.65 / Windows 10 1809
Opera 62.0.3331.72 / Windows 10 1809
Firefox 51.0 / Windows 10 1809
Firefox 68.0 / Windows 10 1809
Firefox Mobile 68.0 / Android 7.2.2
A commit referencing this issue has landed:
Issue 7311 - Split _checkEntryMatchByDomain()