Opened on 03/13/2019 at 07:24:19 AM
Closed on 09/05/2019 at 07:21:09 PM
Last modified on 09/05/2019 at 07:21:37 PM
#7355 closed change (fixed)
Clean up after changes for issue 7000
Reported by: | mjethani | Assignee: | |
---|---|---|---|
Priority: | Unknown | Milestone: | |
Module: | Core | Keywords: | closed-in-favor-of-gitlab |
Cc: | Blocked By: | #7324, #7435 | |
Blocking: | Platform: | Unknown / Cross platform | |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description (last modified by mjethani)
Background
We made a number of changes as part of #7000. Many of these involved hacks and compromises. Now it's time to refactor and simplify the code.
List of changes
Ticket | Status | Resolution | Summary | Component | Owner |
---|---|---|---|---|---|
#7324 | closed | fixed | Simplify logic for domains property | Core | mjethani |
#7435 | closed | fixed | Use request object for filter matching | Core | mjethani |
Attachments (0)
Change History (8)
comment:2 Changed on 03/13/2019 at 07:25:14 AM by mjethani
- Blocked By 7324 added
comment:3 Changed on 04/03/2019 at 10:06:51 AM by mjethani
- Blocked By 7435 added
comment:4 Changed on 09/05/2019 at 06:04:03 PM by greiner
- Component changed from Unknown to Core
comment:5 Changed on 09/05/2019 at 07:18:43 PM by sebastian
- Keywords closed-in-favor-of-gitlab added
- Resolution set to rejected
- Status changed from new to closed
comment:6 Changed on 09/05/2019 at 07:20:58 PM by mjethani
- Resolution rejected deleted
- Status changed from closed to reopened
comment:7 Changed on 09/05/2019 at 07:21:09 PM by mjethani
- Resolution set to fixed
- Status changed from reopened to closed
comment:8 Changed on 09/05/2019 at 07:21:37 PM by mjethani
I have changed the resolution to fixed since two changes have already landed against this.
Note: See
TracTickets for help on using
tickets.
We don't accept new issues here on Trac for this module. Please file an issue on GitLab.